fix: exclude GITHUB_API_URL from agent container when api-proxy is enabled

[Copilot]

The Copilot CLI authentication was failing (401) in the build-test workflow when --enable-api-proxy and --env-all were both active. GITHUB_API_URL was leaking into the agent container, causing the CLI to route its token exchange to api.github.com with the placeholder COPILOT_GITHUB_TOKEN rather than through COPILOT_API_URL → api-proxy (which injects the real token).

Root cause

PR #1303 fixed this for the non---env-all path, but commit 9761e87 (PR #1305, "auto-inject GH_HOST") accidentally re-introduced the unconditional GITHUB_API_URL assignment. The --env-all path was never protected at all.

Changes

• src/docker-manager.ts
  • Add GITHUB_API_URL to EXCLUDED_ENV_VARS when api-proxy is enabled — closes the --env-all leak path
  • Remove the duplicate unconditional assignment re-introduced by PR feat(cli): auto-inject GH_HOST in agent container when GHES detected #1305; consolidate to the existing conditional version (!config.enableApiProxy)

if (config.enableApiProxy) {
  // ...existing key exclusions...
  EXCLUDED_ENV_VARS.add('GITHUB_API_URL'); // ← new: prevents --env-all from leaking it
}
// later, in the !envAll path:
// (removed unconditional assignment; kept only the conditional one below)
if (process.env.GITHUB_API_URL && !config.enableApiProxy) environment.GITHUB_API_URL = ...;

• src/docker-manager.test.ts — two new unit tests verifying GITHUB_API_URL is excluded with envAll + api-proxy enabled and passes through when api-proxy is disabled

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/graphql
  • Triggering command: /usr/bin/gh gh auth status (http block)
  • Triggering command: /usr/bin/gh gh auth status git conf�� get --global de/node/bin/bash user.email (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Fix the failing GitHub Actions workflow agent
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 68420172363
Job URL: https://github.com/github/gh-aw-firewall/actions/runs/23507729062/job/68420172363

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

Fixes Copilot CLI authentication failures when running with --enable-api-proxy and --env-all by preventing GITHUB_API_URL from being passed into the agent container (which can cause token exchange to bypass the api-proxy and fail with 401).

Changes:

• Exclude GITHUB_API_URL from the agent environment when api-proxy is enabled (closing the --env-all leak path).
• Remove the reintroduced unconditional GITHUB_API_URL assignment and consolidate to the conditional !config.enableApiProxy behavior.
• Add unit tests covering GITHUB_API_URL behavior with envAll when api-proxy is enabled vs disabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/docker-manager.ts	Excludes GITHUB_API_URL under api-proxy and consolidates conditional env propagation.
src/docker-manager.test.ts	Adds unit tests to ensure GITHUB_API_URL is excluded with envAll + api-proxy and passes through otherwise.

Comments suppressed due to low confidence (2)

src/docker-manager.ts:463

• The added comment references github/gh-aw#20875, but the rest of this repo tends to reference issues as gh-aw-firewall issue #... or a full GitHub URL (e.g., in src/squid-config.ts). Consider updating this to a consistent, resolvable reference (full URL and correct repo), especially if github/gh-aw isn’t publicly accessible to readers of this codebase.

    // GITHUB_API_URL must be excluded so the Copilot CLI routes ALL requests (including
    // token exchange) through COPILOT_API_URL → api-proxy, not directly to api.github.com.
    // If GITHUB_API_URL is present, the CLI may call api.github.com/copilot_internal/v2/token
    // with the placeholder COPILOT_GITHUB_TOKEN (bypassing the api-proxy injection), causing 401.
    // See: github/gh-aw#20875
    EXCLUDED_ENV_VARS.add('GITHUB_API_URL');

src/docker-manager.ts:600

• Same as above: the inline reference github/gh-aw#20875 is inconsistent with other issue references in this repo (often gh-aw-firewall issue #... or a full URL). Consider switching to a consistent, resolvable reference format here as well.

    // GITHUB_API_URL — only pass when api-proxy is NOT enabled.
    // On GHES, workflows set GITHUB_API_URL to the GHES API endpoint (e.g., https://api.ghes-host).
    // When api-proxy is enabled, Copilot CLI must use COPILOT_API_URL (pointing to the proxy)
    // instead of GITHUB_API_URL, because the proxy correctly routes Copilot API requests to
    // api.enterprise.githubcopilot.com (not the GHES API which lacks Copilot endpoints).
    // GITHUB_API_URL is also excluded via EXCLUDED_ENV_VARS for the --env-all path.
    // See: github/gh-aw#20875
    if (process.env.GITHUB_API_URL && !config.enableApiProxy) environment.GITHUB_API_URL = process.env.GITHUB_API_URL;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The enableApiProxy exclusion list is described as excluding “API keys”, but it now also excludes GITHUB_API_URL for routing/behavior reasons. Consider tweaking the nearby comment to reflect that this block excludes both sensitive credentials and env vars that would interfere with api-proxy routing.

This issue also appears in the following locations of the same file:

• line 458
• line 593

[Copilot]

Test comment references github/gh-aw#20875, which doesn’t match the issue-link style used elsewhere in this repo (often gh-aw-firewall issue #... or a full URL). Consider updating to a consistent, resolvable link so future readers can easily find the context.

Suggested change

	// See: github/gh-aw#20875
	// See: https://github.com/github/gh-aw/issues/20875