fix: add node ecosystem to smoke-codex network allow-list by Mossaka · Pull Request #1533 · github/gh-aw-firewall

Mossaka · 2026-03-31T22:55:19Z

Summary

Add node to network.allowed in smoke-codex.md so npm ci && npm run build (step 8) can reach registry.npmjs.org
Without this, all npm requests are blocked by the firewall, causing the agent to fail before calling add_comment

Root cause identified from run 23810579935: firewall logs showed 8 denied requests to registry.npmjs.org.

Test plan

Smoke Codex workflow passes with safe outputs validated

🤖 Generated with Claude Code

Copilot

Pull request overview

Updates the Smoke Codex workflow network allow-list to include Node/NPM access and adds defense-in-depth validation to prevent Squid config injection when interpolating domains/patterns/URL patterns into squid.conf.

Changes:

Add node to network.allowed for Smoke Codex so npm registry access is permitted.
Add Squid config interpolation guards (rejecting whitespace/null bytes) and strengthen domain/pattern validation against injection characters.
Regenerate the compiled smoke-codex.lock.yml workflow (includes broader workflow/version/config changes beyond the allow-list tweak).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/squid-config.ts`	Adds `assertSafeForSquidConfig` and applies it to interpolated ACL values.
`src/squid-config.test.ts`	Adds tests ensuring injected whitespace/newlines are rejected in generated Squid config.
`src/domain-patterns.ts`	Hardens `validateDomainOrPattern` to reject injection-relevant characters.
`src/domain-patterns.test.ts`	Adds test coverage for rejecting injection characters in domains/patterns.
`src/cli.ts`	Adds CLI-side validation rejecting whitespace/null bytes in `--allow-urls` patterns.
`.github/workflows/smoke-codex.md`	Adds `node` to the workflow network allow-list.
`.github/workflows/smoke-codex.lock.yml`	Regenerated compiled workflow, including the updated allow-list and other workflow/config/version changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-31T22:58:37Z

+  // null bytes, and comment/quote characters are dangerous.
+  // This prevents Squid config injection via --allow-domains.
+  const DANGEROUS_CHARS = /[\s\0"'`;#\\]/;


validateDomainOrPattern says it rejects “control characters”, but DANGEROUS_CHARS only matches whitespace (\s) and \0 (plus a few punctuation chars). Other ASCII control characters like \u0001/\u007f would currently pass validation, which undermines the injection-defense intent and makes the error message misleading. Consider expanding the regex to cover the full control-character range (e.g., \x00-\x1F\x7F) or adjust the wording to match what’s actually rejected.

Suggested change

// null bytes, and comment/quote characters are dangerous.

// This prevents Squid config injection via --allow-domains.

const DANGEROUS_CHARS = /[\s\0"'`;#\\]/;

// null bytes, all ASCII control characters, and comment/quote characters are dangerous.

// This prevents Squid config injection via --allow-domains.

const DANGEROUS_CHARS = /[\x00-\x1F\x7F\s"'`;#\\]/;

Copilot · 2026-03-31T22:58:38Z

+          GH_AW_INFO_ALLOWED_DOMAINS: '["defaults","github","node","playwright"]'
          GH_AW_INFO_FIREWALL_ENABLED: "true"
-          GH_AW_INFO_AWF_VERSION: "v0.24.1"
+          GH_AW_INFO_AWF_VERSION: "v0.25.0"
          GH_AW_INFO_AWMG_VERSION: ""
          GH_AW_INFO_FIREWALL_TYPE: "squid"


This PR’s title/description only calls out adding the node network allow-list entry, but the compiled workflow lock includes additional behavioral changes (e.g., AWF version bump and other regenerated metadata/config). If the intent is only to extend the allow-list, consider regenerating the lock with the same compiler/settings as main (or splitting these changes into a separate PR) so the review surface matches the stated scope.

The Smoke Codex workflow asks the agent to run `npm ci && npm run build` (step 8), but `registry.npmjs.org` was not in the allowed domains list. All 8 npm requests were blocked by the firewall, causing the agent to fail before it could call `add_comment` (the required safe output). Add `node` to `network.allowed` so npm registry traffic is permitted. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-01T05:28:51Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	82.67%	82.77%	📈 +0.10%
Statements	82.34%	82.43%	📈 +0.09%
Functions	81.22%	81.22%	➡️ +0.00%
Branches	75.94%	76.00%	📈 +0.06%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/docker-manager.ts`	85.8% → 86.2% (+0.41%)	85.3% → 85.7% (+0.40%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-04-01T05:32:59Z

Smoke test results (run 23833495697)

✅ GitHub MCP: fix: disable IPv6 in agent container to prevent squid proxy bypass #1544 fix: disable IPv6 in agent container to prevent squid proxy bypass · [WIP] Fix permissions for gh-aw config files in self-hosted runners #1520 [WIP] Fix permissions for gh-aw config files in self-hosted runners
✅ Playwright: github.com title contains "GitHub"
✅ File write: smoke-test-claude-23833495697.txt created
✅ Bash: file content verified

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude for issue #1533

github-actions · 2026-04-01T05:33:04Z

Smoke Test Results — @Mossaka

Test	Result
GitHub MCP: PR #1544 "fix: disable IPv6 in agent container to prevent squid proxy bypass" (`@lpcox`)	✅
GitHub MCP: PR #1539 "feat: add token usage tracking to api-proxy sidecar" (`@lpcox`)	✅
Playwright: github.com title contains "GitHub"	✅
File write + read	✅

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot for issue #1533

github-actions · 2026-04-01T05:34:48Z

Smoke Test: GitHub Actions Services Connectivity ✅

All checks passed:

Service	Check	Result
Redis (`host.docker.internal:6379`)	PING	✅ `PONG`
PostgreSQL (`host.docker.internal:5432`)	`pg_isready`	✅ accepting connections
PostgreSQL `smoketest` DB	`SELECT 1`	✅ returned `1`

Note: redis-cli was not available in the environment; Redis was verified via a raw TCP socket PING.

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-04-01T05:35:09Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #1533 · ◷

github-actions · 2026-04-01T12:49:55Z

Smoke test summary for workflow run 23849149884
PR titles:

fix: disable IPv6 in agent container to prevent squid proxy bypass
feat: add token usage tracking to api-proxy sidecar

GitHub MCP merged PR review: ✅
safeinputs-gh PR query: ❌
Playwright title contains GitHub: ✅
Tavily search returned results: ❌
File write + 6) bash cat verify: ✅
Discussion comment via github-discussion-query: ❌
npm ci && npm run build: ✅
Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex

Copilot AI review requested due to automatic review settings March 31, 2026 22:55

Mossaka added the smoke label Mar 31, 2026

Copilot started reviewing on behalf of Mossaka March 31, 2026 22:55 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

Mossaka force-pushed the fix/smoke-codex-add-node-network branch from 8178998 to d36f439 Compare March 31, 2026 23:36

Mossaka force-pushed the fix/smoke-codex-add-node-network branch from d36f439 to 0009c4f Compare April 1, 2026 05:27

github-actions Bot added the smoke-claude label Apr 1, 2026

github-actions Bot added the smoke-copilot label Apr 1, 2026

github-actions Bot added smoke-services build-test labels Apr 1, 2026

This comment has been minimized.

Sign in to view

Mossaka closed this Apr 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add node ecosystem to smoke-codex network allow-list#1533

fix: add node ecosystem to smoke-codex network allow-list#1533
Mossaka wants to merge 1 commit intomainfrom
fix/smoke-codex-add-node-network

Mossaka commented Mar 31, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

Copilot AI Mar 31, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Mossaka commented Mar 31, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 1, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

github-actions Bot commented Apr 1, 2026

Smoke Test: GitHub Actions Services Connectivity ✅

Uh oh!

github-actions Bot commented Apr 1, 2026

🏗️ Build Test Suite Results

Uh oh!

This comment has been minimized.

github-actions Bot commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants