Skip to content

test: add NET_ADMIN capability verification tests#158

Merged
Mossaka merged 3 commits intomainfrom
copilot/drop-net-admin-capability
Dec 20, 2025
Merged

test: add NET_ADMIN capability verification tests#158
Mossaka merged 3 commits intomainfrom
copilot/drop-net-admin-capability

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025

  • Add NET_ADMIN capability verification tests to robustness.test.ts
  • Document allowed scopes for PR titles in AGENTS.md

Note: The PR title needs to be updated manually in the GitHub UI to remove the (security) scope. Suggested new title: test: add NET_ADMIN capability verification tests

Original prompt

This PR drops NET_ADMIN capability, verify it works by adding to existing integration test scenarios:

#133

Custom agent used: create-agentic-workflow
Design agentic workflows using GitHub Agentic Workflows (gh-aw) extension with interactive guidance on triggers, tools, and security best practices.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove NET_ADMIN capability and update tests test(security): add NET_ADMIN capability verification tests Dec 19, 2025
Copilot AI requested a review from Mossaka December 19, 2025 23:24
@Mossaka Mossaka marked this pull request as ready for review December 19, 2025 23:38
@github-actions
Copy link

github-actions bot commented Dec 19, 2025

Test Coverage Report

Metric Coverage Covered/Total
Lines 81.02% 1230/1518
Statements 80.98% 1261/1557
Functions 78.16% 136/174
Branches 72.56% 410/565
Coverage Thresholds

The project has the following coverage thresholds configured:

  • Lines: 38%
  • Statements: 38%
  • Functions: 35%
  • Branches: 30%

Coverage report generated by `npm run test:coverage`

@Mossaka
Copy link
Collaborator

Mossaka commented Dec 19, 2025

1 similar comment
@Mossaka
Copy link
Collaborator

Mossaka commented Dec 19, 2025

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 19, 2025

fix this failure for PR title: https://github.com/githubnext/gh-aw-firewall/actions/runs/20385188220/job/58585217505?pr=158 and update AGENTS.md

@copilot

The PR title check failed because security is not in the allowed scopes list (cli, docker, squid, proxy, ci, deps).

Updated AGENTS.md (commit f930ca4) to document the allowed scopes for PR titles and added examples.

To fix the CI failure, please update the PR title to: test: add NET_ADMIN capability verification tests (removing the scope).

Copilot AI requested a review from Mossaka December 19, 2025 23:58
@Mossaka
Copy link
Collaborator

Mossaka commented Dec 20, 2025

@copilot still failimg:

Error: Unknown scope "security" found in pull request title "test(security): add NET_ADMIN capability verification tests". Scope must match one of: cli, docker, squid, proxy, ci, deps.

@Mossaka Mossaka changed the title test(security): add NET_ADMIN capability verification tests test: add NET_ADMIN capability verification tests Dec 20, 2025
Copy link
Contributor Author

Copilot AI commented Dec 20, 2025

@copilot still failimg:

Error: Unknown scope "security" found in pull request title "test(security): add NET_ADMIN capability verification tests". Scope must match one of: cli, docker, squid, proxy...

I cannot modify the PR title directly - it needs to be updated in the GitHub UI. Please update the PR title to: test: add NET_ADMIN capability verification tests (removing the (security) scope since it's not in the allowed list).

@Mossaka Mossaka merged commit e3136e9 into main Dec 20, 2025
27 of 29 checks passed
@Mossaka Mossaka deleted the copilot/drop-net-admin-capability branch December 20, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants