perf: tune healthcheck intervals for squid and api-proxy containers#1803
perf: tune healthcheck intervals for squid and api-proxy containers#1803
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
|
Smoke test results — PASS ✅
|
Smoke Test ResultsPR titles: "fix: normalize API target env vars to bare hostnames via URL parsing"; "feat: forward OIDC env vars into agent container"
|
Smoke Test: GitHub Actions Services Connectivity ✅All checks passed:
|
Smoke Test Results — PR #1803
PR: perf: tune healthcheck intervals for squid and api-proxy containers Overall: PASS
|
Chroot Version Comparison Results
Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot environments.
|
|
@copilot what are the implications of the new healthcheck intervals, both good and bad sides? |
Benefits:
Risks/tradeoffs:
|
There was a problem hiding this comment.
Pull request overview
This PR reduces per-invocation startup latency by tuning Docker healthcheck timings for the Squid proxy and api-proxy sidecar, aligning code and documentation with faster readiness expectations.
Changes:
- Updated Squid service healthcheck timing in generated Docker Compose (interval/timeout/start_period).
- Updated api-proxy service healthcheck timing in generated Docker Compose (interval/timeout/start_period).
- Refreshed TypeScript/docs examples to match the new healthcheck configuration.
Show a summary per file
| File | Description |
|---|---|
| src/docker-manager.ts | Lowers Squid and api-proxy healthcheck interval/timeout/start_period to reduce sandbox idle wait before services are marked healthy. |
| src/types.ts | Updates the DockerService healthcheck example values to reflect the tuned timings (and retries=5). |
| docs/api-proxy-sidecar.md | Updates documented api-proxy healthcheck parameters to match the implementation. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
Squid and api-proxy healthchecks use conservative intervals (5s interval, 5-10s start_period) that add ~6-8s idle wait to every sandbox invocation. Both services typically become healthy in 1-2s.
src/docker-manager.ts: Setinterval: '1s',start_period: '2s',timeout: '1s'for both squid and api-proxy healthchecks.retries: 5unchanged.docs/api-proxy-sidecar.md,src/types.ts: Update docs/examples to match.