fix: move codex exec subcommand before model flag in lock files#1807
fix: move codex exec subcommand before model flag in lock files#1807
exec subcommand before model flag in lock files#1807Conversation
Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/c43bcd36-5e1d-4ad6-98ad-47006a67b2c7 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
exec subcommand before model flag in lock files
There was a problem hiding this comment.
Pull request overview
This PR fixes Codex CLI invocations in workflow lock files so optional model overrides (GH_AW_MODEL_AGENT_CODEX / GH_AW_MODEL_DETECTION_CODEX) are applied correctly by ensuring the exec subcommand appears before any -c ... flags.
Changes:
- Reordered arguments in
codexcalls fromcodex [flags] exec ...tocodex exec [flags] ...for agent runs. - Reordered arguments in
codexcalls fromcodex [flags] exec ...tocodex exec [flags] ...for detection runs. - Applied the fix consistently across the two Codex lock workflows (4 total call sites).
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/smoke-codex.lock.yml | Moves exec before -c model=... so model overrides are not ignored in both agent and detection Codex runs. |
| .github/workflows/secret-digger-codex.lock.yml | Same codex exec argument order fix for both agent and detection runs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Smoke Test Results
Overall: PASS
|
🔥 Smoke Test Results — PASS
PR: fix: move codex Overall: PASS ✅
|
Smoke Test ResultsPR titles: "fix: normalize API target env vars to bare hostnames via URL parsing"; "feat: forward OIDC env vars into agent container"
|
Smoke Test: GitHub Actions Services Connectivity ✅
All checks passed.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
The
-c model=...flag was placed before theexecsubcommand in codex invocations, causing model overrides viaGH_AW_MODEL_AGENT_CODEX/GH_AW_MODEL_DETECTION_CODEXto be silently ignored (codex discards unknown top-level flags).Before:
After:
smoke-codex.lock.yml(agent + detection) andsecret-digger-codex.lock.yml(agent + detection)${:+... }expansion ensures correct token separation when the variable is set