chore(deps): bump the all-npm-dependencies group with 14 updates#1810
chore(deps): bump the all-npm-dependencies group with 14 updates#1810
Conversation
Update all production source files to use named imports:
- import { execa } from 'execa' (6 files)
- import { execa, execaSync } from 'execa' (docker-manager.ts)
- Replace all execa.sync() calls with execaSync()
Test files are intentionally not modified.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Change `import execa = require('execa')` to named imports
- Replace `execa.ExecaReturnValue` with `Result` type from execa v9
- Add explicit types to fix implicit 'any' in cleanup.ts and docker-helper.ts
- Use String() coercion for stdout/stderr to handle execa v9 return types
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bumps chalk 4→5, commander 12→14, execa 5→9, TypeScript 5→6, esbuild 0.25→0.28, eslint-plugin-security 3→4, and other deps. Key changes beyond version bumps: - Migrate execa default import to named exports (execa, execaSync) - Add ignoreDeprecations for TS6 moduleResolution deprecation - Add custom Jest resolver for ESM-only package exports maps - Update transformIgnorePatterns for execa transitive ESM deps Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/70a46b4a-1a3c-43cf-96e9-2da7563897d9
|
| Metric | Base | PR | Delta |
|---|---|---|---|
| Lines | 86.22% | 86.34% | 📈 +0.12% |
| Statements | 86.08% | 86.19% | 📈 +0.11% |
| Functions | 87.50% | 87.50% | ➡️ +0.00% |
| Branches | 78.81% | 78.80% | 📉 -0.01% |
📁 Per-file Coverage Changes (2 files)
| File | Lines (Before → After) | Statements (Before → After) |
|---|---|---|
src/cli.ts |
62.1% → 62.2% (+0.12%) | 62.6% → 62.7% (+0.11%) |
src/docker-manager.ts |
86.6% → 87.0% (+0.40%) | 86.0% → 86.5% (+0.40%) |
Coverage comparison generated by scripts/ci/compare-coverage.ts
There was a problem hiding this comment.
Pull request overview
Updates the repository’s npm dependency set (including major-version upgrades) and adjusts production/test code to accommodate breaking changes—most notably migrating execa usage and adding Jest handling for ESM-only packages.
Changes:
- Bumped core dependencies/devDependencies (e.g., chalk v5, commander v14, execa v9, TypeScript v6).
- Migrated
execausage from default/CJS patterns to v9 named exports (execa,execaSync) across source and tests. - Added Jest ESM support enhancements (custom resolver + broader
transformIgnorePatterns) and updated ESM validation tests.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds TS 6 deprecation suppression; compiler output remains CJS. |
| package.json | Updates dependency ranges (chalk/commander/execa) and dev dependency versions. |
| package-lock.json | Locks updated dependency graph for the new versions and transitive deps. |
| jest.config.js | Expands ESM transform allowlist and enables a custom Jest resolver. |
| jest-resolver.js | Adds resolver fallback intended to support ESM-only exports maps. |
| src/docker-manager.ts | Switches to execa/execaSync named exports and replaces execa.sync() usage. |
| src/docker-manager.test.ts | Updates Jest mocking to match execa v9 named exports. |
| src/commands/predownload.ts | Switches to execa named export. |
| src/commands/predownload.test.ts | Updates Jest mocking/assertions for execa v9 named export. |
| src/ssl-bump.ts | Switches to execa named export. |
| src/ssl-bump.test.ts | Switches to execa named export in tests. |
| src/host-iptables.ts | Switches to execa named export. |
| src/host-iptables.test.ts | Switches to execa named export in tests. |
| src/logs/log-streamer.ts | Switches to execa named export. |
| src/logs/log-streamer.test.ts | Switches to execa named export in tests. |
| src/logs/log-discovery.ts | Switches to execa named export. |
| src/logs/log-discovery.test.ts | Switches to execa named export in tests. |
| src/logs/log-aggregator.ts | Switches to execa named export. |
| src/logs/log-aggregator.test.ts | Switches to execa named export in tests. |
| src/jest-esm-config.test.ts | Updates Jest ESM validation to import/use chalk v5 + execa v9. |
| tests/integration/ipv6.test.ts | Updates execa import style for integration test usage. |
| tests/fixtures/awf-runner.ts | Updates execa types to v9 (Result) and normalizes stdout/stderr handling. |
| tests/fixtures/cleanup.ts | Updates execa import style and adds explicit callback typings in parsing logic. |
| tests/fixtures/docker-helper.ts | Updates execa import style; minor typing adjustments. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 21/24 changed files
- Comments generated: 3
| "dependencies": { | ||
| "chalk": "^4.1.2", | ||
| "commander": "^12.0.0", | ||
| "execa": "^5.1.1", | ||
| "chalk": "^5.6.2", | ||
| "commander": "^14.0.3", | ||
| "execa": "^9.6.1", | ||
| "js-yaml": "^4.1.1" |
There was a problem hiding this comment.
Bumping commander to v14 and execa to v9 increases the minimum Node requirements (commander v14 requires Node >=20; execa v9 is ESM-only). This repo’s release pipeline uses pkg (see package.json pkg.targets) which currently targets Node 18; that binary build/runtime will likely break after these bumps. Align the pkg targets (and any CI/release workflow expectations) with the new Node/runtime requirements.
jest-resolver.js
Outdated
| module.exports = (path, options) => { | ||
| try { | ||
| return options.defaultResolver(path, options); | ||
| } catch (error) { | ||
| // If default resolution fails, retry with "import" condition added | ||
| return options.defaultResolver(path, { | ||
| ...options, | ||
| conditions: [...(options.conditions || []), 'import'], | ||
| }); |
There was a problem hiding this comment.
jest-resolver.js retries resolution with an added "import" condition for any resolver error. This can mask unrelated resolution problems (typos, missing files, etc.) and make failures harder to diagnose. Consider only retrying for export-condition related errors (e.g., ERR_PACKAGE_PATH_NOT_EXPORTED / exports resolution failures) and rethrowing the original error when the fallback also fails.
| module.exports = (path, options) => { | |
| try { | |
| return options.defaultResolver(path, options); | |
| } catch (error) { | |
| // If default resolution fails, retry with "import" condition added | |
| return options.defaultResolver(path, { | |
| ...options, | |
| conditions: [...(options.conditions || []), 'import'], | |
| }); | |
| const isExportsResolutionError = (error) => { | |
| if (!error) { | |
| return false; | |
| } | |
| if (error.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') { | |
| return true; | |
| } | |
| const message = typeof error.message === 'string' ? error.message : ''; | |
| return ( | |
| message.includes('Package subpath') || | |
| message.includes('package exports') || | |
| message.includes('conditional exports') || | |
| message.includes('No "exports" main defined') | |
| ); | |
| }; | |
| module.exports = (path, options) => { | |
| try { | |
| return options.defaultResolver(path, options); | |
| } catch (error) { | |
| if (!isExportsResolutionError(error)) { | |
| throw error; | |
| } | |
| try { | |
| return options.defaultResolver(path, { | |
| ...options, | |
| conditions: [...(options.conditions || []), 'import'], | |
| }); | |
| } catch (_fallbackError) { | |
| throw error; | |
| } |
tests/fixtures/cleanup.ts
Outdated
| .map(line => parseInt(line.trim().split(/\s+/)[0])) | ||
| .sort((a, b) => b - a); // Reverse order | ||
| .filter((line: string) => line.includes('FW_WRAPPER')) | ||
| .map((line: string) => parseInt(line.trim().split(/\s+/)[0] ?? '0')) |
There was a problem hiding this comment.
line.trim().split(/\s+/)[0] ?? '0' is misleading because the [0] element is always a string (often ''), so the nullish coalescing fallback will never apply. If the intent is to avoid NaN when parsing, use a non-empty check (e.g., fallback on '') or validate the parsed number before sorting/using it.
| .map((line: string) => parseInt(line.trim().split(/\s+/)[0] ?? '0')) | |
| .map((line: string) => Number.parseInt(line.trim().split(/\s+/)[0] || '', 10)) | |
| .filter((lineNum: number) => !Number.isNaN(lineNum)) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot please fix all the integration tests CI failures. |
- Update jest.integration.config.js with expanded transformIgnorePatterns and custom resolver for ESM-only packages (execa v9, chalk v5) - Improve jest-resolver.js to only retry exports-related errors and rethrow original on fallback failure - Fix cleanup.ts parseInt safety per review feedback - Update pkg targets from node18 to node20 Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/cafb7f2e-857a-4fcd-9d69-8e1ceb50ceba
Fixed in 1c3f40c. The integration test failures were caused by
Also addressed the code review feedback: improved |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS Notes
|
Fixed in 2cf874f. The root cause: Fix: Note: The "Dependency Vulnerability Audit" failure is unrelated — it's about the docs site's transitive deps (defu, vite, lodash-es, yaml). |
Smoke Test: GitHub Actions Services Connectivity ✅All checks passed:
|
Smoke Test Results ✅ PASS
|
🔥 Smoke Test Results
PR: chore(deps): bump the all-npm-dependencies group with 14 updates Overall: PASS
|
|
Smoke Test (Codex) run 24161014851
|
Chroot Version Comparison Results
Overall: ❌ Not all tests passed Python and Node.js versions differ between host and chroot environments. Go matches.
|
Summary
Reimplements #1708 (Dependabot dependency bumps) with all necessary code changes to make tests pass.
Dependency Updates
Key Changes Beyond Version Bumps
execa v5 → v9 migration
import { execa, execaSync } from 'execa'execa.sync()withexecaSync()across all production and test filesExecaReturnValuetype toResultin test fixturesTypeScript 5 → 6 compatibility
"ignoreDeprecations": "6.0"totsconfig.jsonfor the deprecatedmoduleResolution: "node"optionJest ESM handling
jest-resolver.js) to handle ESM-only packages whoseexportsmaps only have"import"conditions (no"require")transformIgnorePatternsto include all ESM-only transitive dependencies of execa (is-plain-obj, human-signals, npm-run-path, etc.)Test updates
jest-esm-config.test.tsto validate actual ESM-only imports (chalk v5, execa v9) instead of preparatory infrastructureVerification
tsc) — cleantsc --noEmit -p tsconfig.check.json) — clean