fix: rewrite squid_https_latency to use background containers#1816
Draft
fix: rewrite squid_https_latency to use background containers#1816
Conversation
Copilot
AI
changed the title
[WIP] Fix squid_https_latency benchmark to capture container stdout
fix: rewrite squid_https_latency to use background containers
Apr 8, 2026
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Contributor
Smoke Test Results
Overall: PASS
|
Contributor
🔥 Smoke Test Results
PR: fix: rewrite squid_https_latency to use background containers Overall: PASS ✅
|
Contributor
Smoke Test: GitHub Actions Services Connectivity ✅
All checks passed. (
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
🔮 The ancient spirits stir, and the smoke path has been walked.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
squid_https_latencybenchmark always reports 0ms because AWF streams container stdout viadocker logs -fwithstdio: 'inherit'—execSync()captures empty string,parseFloat("")→NaN, all iterations skip, fallbackvalues.push(0).Rewritten to use the same background-container pattern as
benchmarkMemory():sleep 30in background, wait forawf-squidto be healthycurl -x http://172.30.0.10:3128directly from host through Squid's proxy portfinallycleanup (kill background process + docker teardown)async,main()updated toawaititThis also gives a cleaner measurement — isolates Squid proxy latency without container startup overhead.