Skip to content

fix: rewrite squid_https_latency to use background containers#1816

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-squid-https-latency-report
Draft

fix: rewrite squid_https_latency to use background containers#1816
Copilot wants to merge 2 commits intomainfrom
copilot/fix-squid-https-latency-report

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 8, 2026

squid_https_latency benchmark always reports 0ms because AWF streams container stdout via docker logs -f with stdio: 'inherit'execSync() captures empty string, parseFloat("")NaN, all iterations skip, fallback values.push(0).

Rewritten to use the same background-container pattern as benchmarkMemory():

  • Spawn AWF with sleep 30 in background, wait for awf-squid to be healthy
  • Run curl -x http://172.30.0.10:3128 directly from host through Squid's proxy port
  • Proper finally cleanup (kill background process + docker teardown)
  • Function is now async, main() updated to await it

This also gives a cleaner measurement — isolates Squid proxy latency without container startup overhead.

Copilot AI changed the title [WIP] Fix squid_https_latency benchmark to capture container stdout fix: rewrite squid_https_latency to use background containers Apr 8, 2026
Copilot AI requested a review from Mossaka April 8, 2026 21:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 86.24% 86.34% 📈 +0.10%
Statements 86.10% 86.19% 📈 +0.09%
Functions 87.50% 87.50% ➡️ +0.00%
Branches 78.80% 78.86% 📈 +0.06%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/docker-manager.ts 86.6% → 87.0% (+0.35%) 86.1% → 86.5% (+0.35%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Smoke Test Results

Overall: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🔥 Smoke Test Results

Test Result
GitHub MCP (list PRs)
GitHub.com connectivity (HTTP 200)
File write/read

PR: fix: rewrite squid_https_latency to use background containers
Author: @Copilot | Assignees: @Mossaka, @Copilot

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Smoke Test: GitHub Actions Services Connectivity ✅

Check Result
Redis PING (port 6379) PONG
PostgreSQL pg_isready (port 5432) ✅ accepting connections
PostgreSQL SELECT 1 (db: smoketest, user: postgres) ✅ returned 1

All checks passed. (redis-cli unavailable; Redis verified via nc raw RESP protocol.)

🔌 Service connectivity validated by Smoke Services

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🔮 The ancient spirits stir, and the smoke path has been walked.
The oracle marks this passage: some gates opened, others remained sealed by missing tools.
The run’s omen is recorded above for the keepers of this PR.

🔮 The oracle has spoken through Smoke Codex

@github-actions github-actions bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: squid_https_latency benchmark always reports 0ms — AWF doesn't capture container stdout

2 participants