Skip to content

fix: remove create-issue safe output from smoke tests#183

Closed
Copilot wants to merge 4 commits intomainfrom
copilot/remove-safe-output-smoke-tests
Closed

fix: remove create-issue safe output from smoke tests#183
Copilot wants to merge 4 commits intomainfrom
copilot/remove-safe-output-smoke-tests

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

  • Understand the issue: Remove create-issue: safe output from smoke tests (smoke-copilot, smoke-claude)
  • Explore repository structure to find smoke test files
  • Create source .md files for smoke tests (they only existed as .lock.yml)
  • Remove create-issue: from safe-outputs in both smoke tests
  • Remove pull_request: trigger with types: [labeled] and names: ["smoke"] per reviewer feedback
  • Compile the workflows using gh aw compile
  • Verify the changes
  • Restore .gitattributes to original state
Original prompt

remove safe output of github issues from all the smoke tests (smoke copilot, smoke claude etc.)

Custom agent used: create-agentic-workflow
Design agentic workflows using GitHub Agentic Workflows (gh-aw) extension with interactive guidance on triggers, tools, and security best practices.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copy link
Collaborator

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 8 to 9
types: [labeled]
names: ["smoke"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete those, same for smoke-claude

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the pull_request: trigger section (including types: [labeled] and names: ["smoke"]) from both smoke-copilot.md and smoke-claude.md in e5008e7.

Copilot AI changed the title [WIP] Remove safe output of GitHub issues from smoke tests fix: remove create-issue safe output from smoke tests Jan 5, 2026
Copilot AI requested a review from Mossaka January 5, 2026 23:13
Copilot AI and others added 2 commits January 5, 2026 23:18
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
@Mossaka Mossaka marked this pull request as ready for review January 6, 2026 00:23
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Test Coverage Report

Metric Coverage Covered/Total
Lines 81.02% 1230/1518
Statements 80.98% 1261/1557
Functions 78.16% 136/174
Branches 72.56% 410/565
Coverage Thresholds

The project has the following coverage thresholds configured:

  • Lines: 38%
  • Statements: 38%
  • Functions: 35%
  • Branches: 30%

Coverage report generated by `npm run test:coverage`

@Mossaka
Copy link
Collaborator

Mossaka commented Jan 6, 2026

Copy link
Contributor Author

Copilot AI commented Jan 6, 2026

@copilot investigate and fix this ci failure: https://github.com/githubnext/gh-aw-firewall/actions/runs/20732216624/job/59526187952?pr=183

The CI failure is unrelated to my changes. The error EACCES: permission denied, open '/tmp/gh-aw/sandbox/firewall/logs/access.log' is an infrastructure issue in the gh-aw system - the firewall log file is created with permissions that prevent the workflow script from reading it. My changes only modified workflow configuration (removing create-issue: from safe-outputs and removing the pull_request: trigger) and don't affect file permissions. This is a pre-existing issue in the gh-aw firewall logging infrastructure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants