Skip to content

fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher#1913

Merged
lpcox merged 3 commits intomainfrom
copilot/fix-code-for-review-comments
Apr 11, 2026
Merged

fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher#1913
lpcox merged 3 commits intomainfrom
copilot/fix-code-for-review-comments

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 11, 2026

Two bugs introduced in the firewall-issue-dispatcher by a previous PR: a duplicated {NUMBER} substitution guidance paragraph and an unintentional cron minute change (1120).

Changes

  • firewall-issue-dispatcher.md

    • Remove duplicate where {NUMBER} is replaced with… paragraph that appeared twice after the URL format block
    • Restore create_issue step as item 1 in Step 3 (was accidentally dropped, leaving the agent with no issue-creation instruction)
    • Add filter note to Step 2: "Do this filtering in your analysis — do NOT make additional API calls"
  • firewall-issue-dispatcher.lock.yml

    • Revert cron from "20 */6 * * *" back to "11 */6 * * *"

Copilot AI changed the title [WIP] Fix code based on comments in review thread fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher Apr 11, 2026
Copilot AI requested a review from lpcox April 11, 2026 15:56
@lpcox lpcox marked this pull request as ready for review April 11, 2026 16:24
@lpcox lpcox requested a review from Mossaka as a code owner April 11, 2026 16:24
Copilot AI review requested due to automatic review settings April 11, 2026 16:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes documentation and scheduling regressions in the Firewall Issue Dispatcher workflow, ensuring the agent instructions are complete and the workflow runs on the intended cadence.

Changes:

  • Add an explicit “no additional API calls” note for local filtering, and restore the missing tracking-issue creation instruction in Step 3.
  • Revert the workflow schedule cron minute from 20 back to 11 to match the prior run timing.
Show a summary per file
File Description
.github/workflows/firewall-issue-dispatcher.md Clarifies local-only filtering and restores the missing Step 3 instruction to create a tracking issue before commenting back.
.github/workflows/firewall-issue-dispatcher.lock.yml Restores the intended cron schedule minute for the dispatcher workflow.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lpcox lpcox merged commit d5f9449 into main Apr 11, 2026
30 of 31 checks passed
@lpcox lpcox deleted the copilot/fix-code-for-review-comments branch April 11, 2026 16:44
@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 85.33% 85.42% 📈 +0.09%
Statements 85.18% 85.27% 📈 +0.09%
Functions 87.45% 87.45% ➡️ +0.00%
Branches 77.69% 77.74% 📈 +0.05%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/docker-manager.ts 85.9% → 86.2% (+0.32%) 85.5% → 85.8% (+0.31%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

Overall: PASS (2/2 verifiable tests passed)

Author: @app/copilot-swe-agent | Assignees: @lpcox, @Copilot

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results ✅ PASS

  • ✅ GitHub MCP: "fix: remove duplicate paragraph..." / "fix: restore create-issue step..."
  • ✅ Playwright: GitHub page title verified
  • ✅ File write: /tmp/gh-aw/agent/smoke-test-claude-24286946585.txt created
  • ✅ Bash: File read back successfully

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔮 Oracle smoke trace for PR #1913

  • fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher ✅
  • fix: restore create-issue step and improve URL format in firewall-issue-dispatcher ✅
  • GitHub MCP review (last 2 merged PRs): ✅
  • safeinputs-gh pr list --repo github/gh-aw-firewall --limit 2 --json number,title,author: ❌
  • Playwright title contains "GitHub": ✅
  • Tavily search ("GitHub Agentic Workflows Firewall"): ❌
  • File write + cat readback: ✅
  • Discussion query/comment (latest discussion): ❌
  • npm ci && npm run build: ✅
    Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: GitHub Actions Services Connectivity ✅

Check Result
Redis PINGhost.docker.internal:6379 PONG
pg_isreadyhost.docker.internal:5432 ✅ accepting connections
psql SELECT 1smoketest DB as postgres ✅ returned 1

All checks passed. (redis-cli not available; used bash /dev/tcp for Redis.)

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx passed ✅ PASS
Node.js execa passed ✅ PASS
Node.js p-limit passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #1913 · ● 976K ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants