fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher#1913
fix: remove duplicate paragraph and revert cron in firewall-issue-dispatcher#1913
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw-firewall/sessions/f2ba5221-c9a5-44b2-aeb6-adaaa3c1e48e Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Fixes documentation and scheduling regressions in the Firewall Issue Dispatcher workflow, ensuring the agent instructions are complete and the workflow runs on the intended cadence.
Changes:
- Add an explicit “no additional API calls” note for local filtering, and restore the missing tracking-issue creation instruction in Step 3.
- Revert the workflow schedule cron minute from
20back to11to match the prior run timing.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/firewall-issue-dispatcher.md | Clarifies local-only filtering and restores the missing Step 3 instruction to create a tracking issue before commenting back. |
| .github/workflows/firewall-issue-dispatcher.lock.yml | Restores the intended cron schedule minute for the dispatcher workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Smoke Test Results
Overall: PASS (2/2 verifiable tests passed) Author:
|
Smoke Test Results ✅ PASS
|
|
🔮 Oracle smoke trace for PR #1913
|
Smoke Test: GitHub Actions Services Connectivity ✅
All checks passed. (
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Two bugs introduced in the firewall-issue-dispatcher by a previous PR: a duplicated
{NUMBER}substitution guidance paragraph and an unintentional cron minute change (11→20).Changes
firewall-issue-dispatcher.mdwhere {NUMBER} is replaced with…paragraph that appeared twice after the URL format blockcreate_issuestep as item 1 in Step 3 (was accidentally dropped, leaving the agent with no issue-creation instruction)firewall-issue-dispatcher.lock.yml"20 */6 * * *"back to"11 */6 * * *"