Skip to content

Harden api-proxy startup healthcheck to reduce early unhealthy flaps #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 3 commits into from
Apr 22, 2026
+8 −4
Merged

Harden api-proxy startup healthcheck to reduce early unhealthy flaps #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5256597
Initial plan
Copilot Apr 22, 2026
7d0ca30
fix: harden api-proxy startup healthcheck timing
Copilot Apr 22, 2026
d0e87f3
test: keep api-proxy healthcheck assertions type-safe
Copilot Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/docker-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2365,7 +2365,11 @@ describe('docker-manager', () => {
const result = generateDockerCompose(configWithProxy, mockNetworkConfigWithProxy);
const proxy = result.services['api-proxy'];
expect(proxy.healthcheck).toBeDefined();
expect((proxy.healthcheck as any).test).toEqual(['CMD', 'curl', '-f', 'http://localhost:10000/health']);
const healthcheck = proxy.healthcheck!;
expect(healthcheck.test).toEqual(['CMD', 'curl', '-f', 'http://localhost:10000/health']);
expect(healthcheck.timeout).toBe('2s');
expect(healthcheck.retries).toBe(10);
expect(healthcheck.start_period).toBe('10s');
});

it('should drop all capabilities', () => {
Expand Down
6 changes: 3 additions & 3 deletions src/docker-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,9 +1773,9 @@ export function generateDockerCompose(
healthcheck: {
test: ['CMD', 'curl', '-f', `http://localhost:${API_PROXY_HEALTH_PORT}/health`],
interval: '1s',
timeout: '1s',
retries: 5,
start_period: '2s',
timeout: '2s',
retries: 10,
start_period: '10s',
},
// Security hardening: Drop all capabilities
cap_drop: ['ALL'],
Expand Down
Loading