Skip to content

[Test Coverage] Add comprehensive tests for image-tag module #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 4 commits into from
Apr 27, 2026
Merged

[Test Coverage] Add comprehensive tests for image-tag module #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0a13b2
test: add comprehensive tests for image-tag module
github-actions[bot] Apr 27, 2026
675cfbe
Update src/image-tag.test.ts
lpcox Apr 27, 2026
486c0b1
fix: update .copilot mount tests for skip-if-missing behavior
lpcox Apr 27, 2026
8a045ef
fix: bump security-guard max-turns from 6 to 10
lpcox Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions .github/workflows/security-guard.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/security-guard.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions:
issues: read
engine:
id: claude
max-turns: 6
max-turns: 10
tools:
github:
mode: gh-proxy
Expand Down
18 changes: 13 additions & 5 deletions src/docker-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,13 +874,16 @@ describe('docker-manager', () => {
expect(volumes).toContain(`${homeDir}/.claude:/host${homeDir}/.claude:rw`);
expect(volumes).toContain(`${homeDir}/.anthropic:/host${homeDir}/.anthropic:rw`);
expect(volumes).toContain(`${homeDir}/.gemini:/host${homeDir}/.gemini:rw`);
// ~/.copilot is mounted from host, with session-state and logs overlaid from AWF workDir
expect(volumes).toContain(`${homeDir}/.copilot:/host${homeDir}/.copilot:rw`);
// ~/.copilot is only mounted if it already exists on the host
if (fs.existsSync(path.join(homeDir, '.copilot'))) {
expect(volumes).toContain(`${homeDir}/.copilot:/host${homeDir}/.copilot:rw`);
}
// session-state and logs are always overlaid from AWF workDir
expect(volumes).toContain(`/tmp/awf-test/agent-session-state:/host${homeDir}/.copilot/session-state:rw`);
expect(volumes).toContain(`/tmp/awf-test/agent-logs:/host${homeDir}/.copilot/logs:rw`);
});

it('should create missing .copilot directory and mount it when using non-standard HOME path', () => {
it('should skip .copilot bind mount when directory does not exist at non-standard HOME path', () => {
const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'awf-home-'));
const originalHome = process.env.HOME;
const originalSudoUser = process.env.SUDO_USER;
Expand All @@ -894,8 +897,13 @@ describe('docker-manager', () => {
const result = generateDockerCompose(mockConfig, mockNetworkConfig);
const volumes = result.services.agent.volumes as string[];

expect(fs.existsSync(copilotDir)).toBe(true);
expect(volumes).toContain(`${fakeHome}/.copilot:/host${fakeHome}/.copilot:rw`);
// Directory should NOT be auto-created (changed in #2114)
expect(fs.existsSync(copilotDir)).toBe(false);
// The blanket .copilot mount should be absent
expect(volumes).not.toContain(`${fakeHome}/.copilot:/host${fakeHome}/.copilot:rw`);
// But session-state and logs overlays are always present
expect(volumes).toContainEqual(expect.stringContaining(`${fakeHome}/.copilot/session-state:rw`));
expect(volumes).toContainEqual(expect.stringContaining(`${fakeHome}/.copilot/logs:rw`));
} finally {
if (originalHome !== undefined) {
process.env.HOME = originalHome;
Expand Down
Loading
Loading