Skip to content

chore: delete existing firewall tests and migrate smoke tests#229

Merged
Mossaka merged 5 commits intomainfrom
copilot/delete-firewall-tests-migrate-smoke
Jan 17, 2026
Merged

chore: delete existing firewall tests and migrate smoke tests#229
Mossaka merged 5 commits intomainfrom
copilot/delete-firewall-tests-migrate-smoke

Conversation

Copy link
Contributor

Copilot AI commented Jan 17, 2026

  • Delete existing firewall tests (tests/integration/basic-firewall.test.ts, tests/integration/robustness.test.ts, tests/integration/claude-code.test.ts)
  • Delete existing firewall test workflows (.github/workflows/test-integration.yml, .github/workflows/test-claude.yml, .github/workflows/firewall-escape-test.md, .github/workflows/firewall-escape-test.lock.yml)
  • Delete old smoke test lock files (smoke-claude.lock.yml, smoke-copilot.lock.yml)
  • Create smoke-claude.md, smoke-codex.md, smoke-copilot.md
  • Compile smoke tests using gh aw compile
  • Update tests/README.md documentation
  • Update tests/TEST_RESULTS.md documentation
  • Update references in AGENTS.md, CLAUDE.md, docs/quickstart.md
  • Update scripts/download-latest-artifact.sh defaults
  • Configure smoke tests to trigger on every PR (opened, synchronize, reopened)
  • Remove create-issue capability from smoke tests

Summary

This PR deletes existing firewall tests and migrates smoke tests from gh-aw repository.

Key changes:

  • Removed TypeScript integration tests (basic-firewall, robustness, claude-code)
  • Removed associated workflow files (test-integration.yml, test-claude.yml, firewall-escape-test)
  • Created new smoke test markdown files for Claude, Codex, and Copilot engines
  • Compiled smoke tests with gh aw compile to generate .lock.yml files
  • Smoke tests now trigger on every PR (opened, synchronize, reopened) instead of only on labeled PRs
  • Removed create-issue from safe-outputs in all smoke tests
  • Updated all documentation references
Original prompt

delete existing firewall tests and then migrate these smoke tests

https://github.com/githubnext/gh-aw/blob/main/.github/workflows/smoke-claude.md
https://github.com/githubnext/gh-aw/blob/main/.github/workflows/smoke-codex.md
https://github.com/githubnext/gh-aw/blob/main/.github/workflows/smoke-copilot.md

The important difference is that they should be using locally built firewall for testing purposes instead of released version


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 17, 2026 04:25
- Delete basic-firewall.test.ts, robustness.test.ts, claude-code.test.ts
- Delete test-integration.yml, test-claude.yml, firewall-escape-test.md/.lock.yml
- Delete old smoke-claude.lock.yml, smoke-copilot.lock.yml
- Add smoke-claude.md with local-build sandbox config
- Add smoke-codex.md with local-build sandbox config
- Add smoke-copilot.md with local-build sandbox config
- Update tests/README.md and TEST_RESULTS.md documentation
- Update references in AGENTS.md, CLAUDE.md, quickstart.md
- Update download-latest-artifact.sh defaults

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
@@ -0,0 +1,71 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot generate those smoke tests using gh aw compile and push

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in abc7195. Compiled the smoke tests with gh aw compile and generated the .lock.yml files for smoke-claude, smoke-codex, and smoke-copilot.

Copilot AI changed the title [WIP] Delete existing firewall tests and migrate smoke tests chore: delete existing firewall tests and migrate smoke tests Jan 17, 2026
Copilot AI requested a review from Mossaka January 17, 2026 04:30
- Update smoke-claude.md, smoke-codex.md, smoke-copilot.md with correct sandbox config
- Generate smoke-claude.lock.yml, smoke-codex.lock.yml, smoke-copilot.lock.yml

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Comment on lines 4 to 9
schedule: every 12h
workflow_dispatch:
pull_request:
types: [labeled]
names: ["smoke"]
reaction: "heart"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot modify all the smoke tests to be triggered on every PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ae84524. Changed pull_request trigger from types: [labeled] to types: [opened, synchronize, reopened] so smoke tests run on every PR.

Comment on lines 41 to 51
add-comment:
hide-older-comments: true
create-issue:
expires: 2h
add-labels:
allowed: [smoke-claude]
messages:
footer: "> 💥 *[THE END] — Illustrated by [{workflow_name}]({run_url})*"
run-started: "💥 **WHOOSH!** [{workflow_name}]({run_url}) springs into action on this {event_type}! *[Panel 1 begins...]*"
run-success: "🎬 **THE END** — [{workflow_name}]({run_url}) **MISSION: ACCOMPLISHED!** The hero saves the day! ✨"
run-failure: "💫 **TO BE CONTINUED...** [{workflow_name}]({run_url}) {status}! Our hero faces unexpected challenges..."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot delete create issue for every smoke tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ae84524. Removed create-issue from safe-outputs in all three smoke tests.

- Change pull_request trigger from labeled to [opened, synchronize, reopened]
- Remove create-issue from safe-outputs in all smoke tests
- Recompile smoke tests with gh aw compile

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot AI requested a review from Mossaka January 17, 2026 08:58
@Mossaka Mossaka marked this pull request as ready for review January 17, 2026 09:06
@github-actions
Copy link

Test Coverage Report

Metric Coverage Covered/Total
Lines 77.19% 1300/1684
Statements 77.27% 1333/1725
Functions 77.17% 142/184
Branches 69.76% 450/645
Coverage Thresholds

The project has the following coverage thresholds configured:

  • Lines: 38%
  • Statements: 38%
  • Functions: 35%
  • Branches: 30%

Coverage report generated by `npm run test:coverage`

activated: ${{ steps.check_membership.outputs.is_team_member == 'true' }}
steps:
- name: Setup Scripts
uses: githubnext/gh-aw/actions/setup@v0.36.0

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Smoke Codex' step
Uses Step
uses 'githubnext/gh-aw/actions/setup' with ref 'v0.36.0', not a pinned commit hash
This was referenced Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants