revert: remove docker-wrapper (docker-in-docker not supported) #428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the docker-wrapper implementation as Docker-in-Docker support was intentionally removed in v0.9.1 (PR #205). Running
docker runinside the agent container is not a supported use case in the current AWF architecture.Changes Reverted
All changes from the original implementation have been reverted:
containers/agent/docker-wrapper.sh- Docker wrapper script that was created to inject--add-hostflagscontainers/agent/Dockerfile- Removed docker-wrapper installationcontainers/agent/entrypoint.sh- Removed AWF_ENABLE_HOST_ACCESS readonly declarationsrc/docker-manager.ts- Removed AWF_ENABLE_HOST_ACCESS environment variable passingsrc/docker-manager.test.ts- Removed tests for AWF_ENABLE_HOST_ACCESSRationale
The original feature request was based on a misunderstanding of the AWF architecture. Docker-in-Docker was intentionally removed to:
The agent container is designed to work without Docker commands available, and spawning containers from within the agent is not supported.
Status
This PR should be closed as the requested feature conflicts with the intentional removal of Docker-in-Docker support.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.