-
Notifications
You must be signed in to change notification settings - Fork 2
fix: switch security-guard workflow to claude engine #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
✅ Coverage Check PassedOverall Coverage
Coverage comparison generated by |
|
Smoke Test Results Last 2 Merged PRs:
✅ GitHub MCP: PASS Status: PASS
|
Security Review: Informational NotesI've completed a security review of this PR. The changes do not introduce critical security vulnerabilities, but there are two areas where the security boundary has been slightly expanded compared to the previous Copilot configuration. These changes appear operationally justified for Claude engine support. ✅ No Core Firewall ChangesAll firewall implementation code remains unchanged:
ℹ️ Expanded Network Access (Expected for Claude)File: The allowed domains list expanded from 9 Copilot-specific domains to 50+ Claude-specific domains: Key additions:
Analysis: The ℹ️ Expanded Filesystem AccessFile: Container mounts changed from individual binaries to directory: Before: Analysis: This mount provides access to all GitHub Actions pre-installed tools rather than specific binaries. While mounted read-only ( 🔒 Security Boundary AssessmentRisk Level: Low Both expansions are:
RecommendationThese changes are acceptable as they:
No blocking security concerns identified. ✅
|
Security Guard workflow failed on PR #369 because
COPILOT_GITHUB_TOKENsecret is not configured. Switched to Claude engine which uses existingCLAUDE_CODE_OAUTH_TOKEN/ANTHROPIC_API_KEYsecrets.Changes
.github/workflows/security-guard.md: Addedengine: { id: claude }to frontmatter.github/workflows/*.lock.yml: Recompiled all workflows withgh aw compile(v0.37.26)Engine Change
Secret validation now checks for Claude credentials instead of Copilot:
COPILOT_GITHUB_TOKEN(not configured) → workflow failsCLAUDE_CODE_OAUTH_TOKENORANTHROPIC_API_KEY(configured) → workflow succeedsSide Effects
All agentic workflows updated to gh-aw v0.37.26 from v0.37.3 as part of the recompilation. Changes include:
actions/checkoutv5→v6,actions/setup-nodeupdates)agentics-maintenance.ymlworkflow from frameworkSecurity review functionality unchanged.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.