Completing task#1843
Merged
lpcox merged 2 commits intoclaude/go-fan-review-wazero-modulefrom Mar 13, 2026
Merged
Conversation
Replace deprecated InstantiateModuleFromBinary with InstantiateWithConfig to fix lint error in GitHub Actions workflow. The wazero API changed and InstantiateModuleFromBinary no longer exists. Updated test to use runtime.InstantiateWithConfig with a ModuleConfig, matching the pattern used in the production code (wasm.go:111). Fixes: internal/guard/wasm_test.go:108
Claude created this pull request from a session on behalf of
lpcox
March 13, 2026 15:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WASM guard test suite to use the current wazero instantiation API, aligning tests with the runtime/module configuration pattern used elsewhere in the codebase.
Changes:
- Replaces deprecated
runtime.InstantiateModuleFromBinaryusage withruntime.InstantiateWithConfig. - Introduces a
wazero.ModuleConfigwith an explicit module name for the blocking guard module used in context-cancellation testing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent