fix: suppress staticcheck SA1012 for intentional nil context test#1895
Merged
fix: suppress staticcheck SA1012 for intentional nil context test#1895
Conversation
The test deliberately passes nil to verify GetAgentTagsSnapshotFromContext handles nil context gracefully. Add nolint directive to suppress SA1012. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Suppresses staticcheck SA1012 in a unit test that intentionally passes a nil context.Context to verify graceful handling in GetAgentTagsSnapshotFromContext.
Changes:
- Adds
//nolint:staticchecksuppression for the intentionalnilcontext test case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
staticcheckSA1012 lint error insdk_method_dispatch_test.go. The test intentionally passesniltoGetAgentTagsSnapshotFromContextto verify graceful nil handling. Addednolint:staticcheckdirective.make agent-finishedpasses cleanly.