fix: eliminate duplicate sys tool delegation block via callSysServer helper#1910
Merged
fix: eliminate duplicate sys tool delegation block via callSysServer helper#1910
Conversation
Copilot created this pull request from a session on behalf of
lpcox
March 14, 2026 23:12
View session
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the duplicate code issue for the sys tool
sysServerdelegation block ininternal/server/unified.go.The two sys-tool handler closures (
sysInitHandlerandsysListHandler) previously contained an identical ~10-line block that:tools/callparams object with the tool nameus.sysServer.HandleRequest("tools/call", ...)nil, result, nilChanges
callSysServer(toolName string) (interface{}, error)helper method onUnifiedServerthat centralises the marshal →HandleRequest→ error check → return patternsysInitHandlerandsysListHandlerto delegate to the helper, keeping only their tool-specific pre-call logic and log messagessys_*tools without copy-pasting the delegation blockImplementation Checklist
callSysServer(toolName string)helper onUnifiedServersysInitHandlerto use helpersysListHandlerto use helpersys_*tools follow the helper patternmake agent-finished)Resolves: [duplicate-code] Duplicate Code Pattern: Sys Tool sysServer Delegation Block