Conversation
…w error wrapping Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lpcox
March 15, 2026 00:00
View session
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a dead *toml.ParseError pointer type assertion (since toml.Decode returns ParseError by value) and switches to %w error wrapping to preserve the structured error and surface richer parse context.
Changes:
- Removed unreachable pointer assertion branch for
*toml.ParseError - Replaced manual line/column error formatting with
%wwrapping oftoml.ParseError - Updated package doc comment to reflect the new error-wrapping approach
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the High and Medium priority findings from the BurntSushi/toml Go module review.
Changes
Remove dead
*toml.ParseErrorpointer assertion (config_core.go)toml.Decodealways returnsParseErroras a value type, so theerr.(*toml.ParseError)pointer assertion could never match. This was misleading dead code with a stale comment claiming it was needed for "compatibility".Use
%wwrapping for richer parse error messagesReplaced:
With:
This surfaces
ParseError.Error()'s full formatted output — including the TOML source line and a^column pointer — giving users much better context when their config has a syntax error. It also preserves the structuredParseErrortype for callers usingerrors.As.Before:
After:
Update package doc comment
Reflects the new error-wrapping approach instead of the old manual field extraction.
Testing
All unit and integration tests pass (
make agent-finished).