fix: remove unused cleared variable causing lint failure#2038
Merged
lpcox merged 2 commits intolog/difc-sink-server-ids-37cf5ef4349005f5from Mar 16, 2026
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [67273885685] Fix failing GitHub Actions workflow lint
fix: remove unused Mar 16, 2026
cleared variable causing lint failure
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI lint failure caused by a declared-but-never-read variable cleared in internal/difc/sink_server_ids.go. The variable was assigned but its value was never consumed before the function returned.
Changes:
- Removed the unused
cleared booldeclaration and its assignment inSetSinkServerIDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI lint job was failing due to a declared-but-never-read variable
clearedininternal/difc/sink_server_ids.go. The variable was assignedtruein the empty-input early-return branch but the function returns immediately after, so the value was never consumed.Change
internal/difc/sink_server_ids.go: Removecleared boolfrom thevarblock and drop its assignment — the existinglogSink.Printcall already communicates the clearing behaviour.Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.