fix: restore #[allow(dead_code)] on is_bot helper#2074
Merged
Conversation
The annotation was accidentally removed by commit dd179ba when cleaning up stale #[allow(dead_code)] attributes. The is_bot() function is still only used by test code in permissions.rs, so it needs the suppression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Restores the #[allow(dead_code)] lint suppression on the labels::helpers::is_bot() helper, which is part of the public labels API surface but (currently) only referenced from test code—preventing dead_code warnings in non-test builds.
Changes:
- Re-add
#[allow(dead_code)]tois_bot()inlabels/helpers.rs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This was referenced Mar 17, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#[allow(dead_code)]annotation onis_bot()inhelpers.rswas accidentally removed by commit dd179ba when cleaning up stale dead_code attributes. The function is only used by test code inpermissions.rs, so it still needs the suppression.Change: Add
#[allow(dead_code)]back tois_bot()(1 line).Tests: 57/57 pass, WASM build verified.