fix: suppress dead_code warning on is_forked_pull_request_with_callback#2118
Merged
fix: suppress dead_code warning on is_forked_pull_request_with_callback#2118
Conversation
Add #[allow(dead_code)] to is_forked_pull_request_with_callback, which is only called from tests (same pattern as is_bot and is_owner helpers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR suppresses a Rust dead_code warning for a GitHub-guard labeling backend helper that is only exercised from tests, aligning it with existing helper patterns in the codebase.
Changes:
- Added
#[allow(dead_code)]tois_forked_pull_request_with_callbackto eliminate unused-function warnings during non-test builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
#[allow(dead_code)]tois_forked_pull_request_with_callbackinbackend.rs.This function is only called from tests (same pattern as
is_bot,is_owner, andis_repo_privatehelpers which already have the annotation).Before:
warning: functionis_forked_pull_request_with_callbackis never usedAfter: Clean build, 66 tests pass, zero warnings.