[Repo Assist] test: add unit tests for ConvertToCallToolResult, ParseToolArguments, and sink server IDs

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Adds unit tests for two previously untested modules:

internal/mcp/tool_result_test.go

Tests ConvertToCallToolResult — the backend result conversion function:

• JSON array input is wrapped as a single TextContent item
• Standard MCP format with text content items is converted correctly
• Empty content array is preserved as zero items
• isError: true is propagated to the result
• Object without a content field is wrapped as text
• Unknown content types (e.g. "image") fall back to text
• Simple string input is wrapped as text

Tests ParseToolArguments — argument extraction from CallToolRequest:

• Nil Arguments returns an empty map (not nil)
• Valid JSON is parsed into the expected map
• Nested object arguments are parsed correctly
• Invalid JSON returns a descriptive error
• Empty JSON object {} returns empty map

internal/difc/sink_server_ids_test.go

Tests SetSinkServerIDs:

• Empty/nil slice clears previous configuration
• Configured IDs match correctly
• Unconfigured IDs do not match
• Duplicates are deduplicated
• Empty strings in input are skipped
• Calling again replaces previous configuration

Tests IsSinkServerID:

• Returns false when no IDs are configured
• Returns true for exact match
• Returns false for partial/prefix/suffix matches
• Is case-sensitive
• Is safe under concurrent access (sync.WaitGroup goroutine test)

Test Status

⚠️ Infrastructure note: The environment has Go 1.24.13 but go.mod requires Go 1.25.0 (the toolchain download is blocked by the network firewall). Tests could not be executed locally. Both files pass gofmt formatting checks. The logic follows established patterns in the codebase and the tests are straightforward unit tests of pure functions / simple concurrent state.

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"

See Network Configuration for more information.

[Copilot]

Pull request overview

This PR adds new unit test coverage for MCP tool-result handling and DIFC sink server ID configuration, strengthening validation of core conversion/parsing helpers and the sink-ID matching behavior.

Changes:

• Added unit tests for ConvertToCallToolResult covering common backend payload shapes and edge cases.
• Added unit tests for ParseToolArguments covering nil/valid/invalid JSON argument handling.
• Added unit tests for SetSinkServerIDs / IsSinkServerID covering clearing, dedup/skip-empty behavior, and matching semantics.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
internal/mcp/tool_result_test.go	Adds unit tests for tool result conversion and tool-argument parsing helpers.
internal/difc/sink_server_ids_test.go	Adds unit tests for sink server ID configuration and matching behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.