Fix golangci-lint CI failures in internal/proxy/handler.go#2189
Merged
lpcox merged 2 commits intofeat/proxy-modefrom Mar 19, 2026
Merged
Fix golangci-lint CI failures in internal/proxy/handler.go#2189lpcox merged 2 commits intofeat/proxy-modefrom
lpcox merged 2 commits intofeat/proxy-modefrom
Conversation
…ype switch Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/7feddbce-4f91-48ec-9a03-dba7585fca09
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow lint
Fix golangci-lint CI failures in internal/proxy/handler.go
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes golangci-lint/staticcheck failures in the proxy handler by removing unused code and making a type switch idiomatic, unblocking the lint CI job for the proxy package.
Changes:
- Removed the unused
forwardGraphQLmethod (confirmed no remaining references in the repo). - Refactored
writeEmptyResponseto use an assigned type switch form, removing the redundant type assertion in themap[string]interface{}case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two staticcheck violations introduced in
internal/proxy/handler.gowere causing the lint CI job to fail.Changes
forwardGraphQL: Dead code — defined but never called. GraphQL forwarding is handled inline inhandleWithDIFC.map[string]interface{}case by using the idiomatic assigned type switch form:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build1696049945/b333/launcher.test /tmp/go-build1696049945/b333/launcher.test -test.testlogfile=/tmp/go-build1696049945/b333/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build1696049945/b238/vet.cfg go o x_amd64/compile(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build1696049945/b318/config.test /tmp/go-build1696049945/b318/config.test -test.testlogfile=/tmp/go-build1696049945/b318/testlog.txt -test.paniconexit0 -test.timeout=10m0s ncod�� 64/src/runtime/cgo 64/src/encoding/asn1/asn1.go x_amd64/asm(dns block)nonexistent.local/tmp/go-build1696049945/b333/launcher.test /tmp/go-build1696049945/b333/launcher.test -test.testlogfile=/tmp/go-build1696049945/b333/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build1696049945/b238/vet.cfg go o x_amd64/compile(dns block)slow.example.com/tmp/go-build1696049945/b333/launcher.test /tmp/go-build1696049945/b333/launcher.test -test.testlogfile=/tmp/go-build1696049945/b333/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build1696049945/b238/vet.cfg go o x_amd64/compile(dns block)this-host-does-not-exist-12345.com/tmp/go-build1696049945/b342/mcp.test /tmp/go-build1696049945/b342/mcp.test -test.testlogfile=/tmp/go-build1696049945/b342/testlog.txt -test.paniconexit0 -test.timeout=10m0s /tmp/go-build1696049945/b215/vet.cfg p/go-build linux.go x_amd64/compile --exclude-hidden/opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linux_amd64/vet terpreter --quiet x_amd64/compile 2599�� ache/go/1.25.8/x-errorsas AcPk/Gl1SDLLxjjl-ifaceassert x_amd64/vet(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.