fix(difc): use human-readable secrecy level in write-denial reason#2205
Merged
lpcox merged 2 commits intofix/difc-error-messagesfrom Mar 20, 2026
Merged
fix(difc): use human-readable secrecy level in write-denial reason#2205lpcox merged 2 commits intofix/difc-error-messagesfrom
lpcox merged 2 commits intofix/difc-error-messagesfrom
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/cfe43072-48d3-4ed2-bad2-4583d326138a
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on improving DIFC error messages and sentinel replacement
fix(difc): use human-readable secrecy level in write-denial reason
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves DIFC write-denial messaging by making secrecy violation reasons human-readable and consistent with existing read-denial formatting, while keeping raw tag details in logs/debug output.
Changes:
- Update
evaluateWritesecrecy-denialReasonto useformatSecrecyLevel(extraTags)instead of printing the raw tag slice. - Adjust the wording of the write-secrecy denial message to match the style of other user-facing DIFC denial messages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The write-secrecy denial
Reasonexposed raw internal tag slices (e.g.[private:owner/repo]) in the user-facing message, inconsistent with read-denial messages which already useformatSecrecyLevel/formatIntegrityLevel.Changes
internal/difc/evaluator.go: Replace%v extraTagswithformatSecrecyLevel(extraTags)in the write-secrecy denialReason, producing e.g."private (owner/repo)"instead of[private:owner/repo].Before:
After:
Raw tag details remain available in the debug log (
extraTags=%v) and inFormatViolationError's "Current Agent Labels" output.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.