test: add unit tests for internal/httputil package#2800
Merged
Conversation
Adds comprehensive tests for WriteJSONResponse covering: - Content-Type header setting - Status code propagation (200, 201, 400, 404, 500) - JSON encoding of structs, maps, slices, nested types - Nil body, empty struct, special characters, unicode Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds initial unit test coverage for internal/httputil.WriteJSONResponse, the shared helper used by HTTP-facing packages (e.g., server/proxy) to emit JSON responses.
Changes:
- Introduces a new
internal/httputil/httputil_test.gowith subtests covering headers, status codes, and JSON encoding for multiple body shapes. - Adds edge-case assertions for nil/empty bodies and for payloads containing special characters and unicode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the
internal/httputilpackage, which previously had no test coverage.Tests Added
10 test cases for
WriteJSONResponse:application/json)Verification
make agent-finished✅