[Repo Assist] refactor(server): remove writeJSONResponse passthrough wrapper

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Removes the private writeJSONResponse function from internal/server/http_helpers.go, which was a pure one-liner passthrough to httputil.WriteJSONResponse with no added behaviour. The 4 call sites are updated to use httputil.WriteJSONResponse directly.

Motivation

Identified in #2987 (Semantic Function Clustering analysis) as a "< 30 min" quick win:

internal/server/http_helpers.go:22 defines a private one-liner that simply delegates to httputil.WriteJSONResponse — 4 call sites inside internal/server/ use the wrapper instead of the public function directly. Recommendation: Remove and update callers. Zero behaviour change, eliminates one indirection layer.

Changes

File	Change
internal/server/http_helpers.go	Removed writeJSONResponse; writeErrorResponse now calls httputil.WriteJSONResponse directly
internal/server/handlers.go	Added httputil import; 2 call sites updated
internal/server/health.go	Added httputil import; 1 call site updated
internal/server/routed.go	Added httputil import; 1 call site updated

Test Status

⚠️ Infrastructure failure: The build environment does not have Go 1.25.0 available (required by go.mod) and the toolchain download is blocked by the network firewall. The changes are a mechanical rename with no logic changes — the type signatures and behaviour are identical to the wrapper being removed. CI in GitHub Actions should pass normally.

Closes part of #2987 (the quick-win checklist item for writeJSONResponse).

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

Removes the private writeJSONResponse helper from internal/server/http_helpers.go (a pure passthrough to internal/httputil.WriteJSONResponse) and updates server handlers to call httputil.WriteJSONResponse directly, reducing indirection in the internal/server package.

Changes:

• Deleted writeJSONResponse from internal/server/http_helpers.go.
• Updated writeErrorResponse to call httputil.WriteJSONResponse directly.
• Updated 4 call sites across server handlers/middleware to use httputil.WriteJSONResponse and added the required imports.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
internal/server/http_helpers.go	Removes the one-line wrapper and routes error responses directly through httputil.WriteJSONResponse.
internal/server/handlers.go	Replaces wrapper usage with httputil.WriteJSONResponse for /close responses and adds import.
internal/server/health.go	Replaces wrapper usage with httputil.WriteJSONResponse for /health response and adds import.
internal/server/routed.go	Replaces shutdown middleware response writer with httputil.WriteJSONResponse and adds import.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.