Fix search_repositories query parameter URL encoding#3235
Merged
Conversation
The search_repositories case in restBackendCaller.CallTool was not URL-encoding the query parameter before embedding it in the API path. Characters like spaces and '>' in queries (e.g. 'language:go stars:>1000') produced malformed HTTP request URIs, causing the upstream server to reject them with HTTP 400 instead of forwarding to the /search/repositories endpoint. Use url.QueryEscape to properly encode the query value. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes malformed GitHub REST API requests generated by the proxy’s restBackendCaller for the search_repositories tool by URL-encoding the q query parameter before constructing the upstream request path.
Changes:
- URL-encode
search_repositories’squeryargument viaurl.QueryEscape()when building/search/repositoriesAPI paths.
Show a summary per file
| File | Description |
|---|---|
| internal/proxy/proxy.go | Escapes the q query parameter for search_repositories to prevent invalid request URIs and upstream 400s. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestRestBackendCaller_SearchRepositories_APIErrorwas failing because thesearch_repositoriescase inrestBackendCaller.CallToolwas not URL-encoding the query parameter before embedding it in the API path.Queries containing spaces or special characters (e.g.
language:go stars:>1000) produced malformed HTTP request URIs, causing the upstream server to reject them with HTTP 400 instead of the expected status code.Fix
Use
url.QueryEscape()to properly encode the query value before building the API path.Verification
make agent-finishedpasses — all unit and integration tests green.