Skip to content

Fix: log HTTP connection errors to stderr for operator visibility #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Apr 10, 2026
Merged

Fix: log HTTP connection errors to stderr for operator visibility #3514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/launcher/launcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ func GetOrLaunch(l *Launcher, serverID string) (*mcp.Connection, error) {
// Create an HTTP connection
conn, err := mcp.NewHTTPConnection(l.ctx, serverID, serverCfg.URL, serverCfg.Headers, oidcProvider, oidcAudience, l.config.Gateway.HTTPKeepaliveInterval())
if err != nil {
log.Printf("FAILED to create HTTP connection for server %q: %v", serverID, err)
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new stderr log prints the raw err from mcp.NewHTTPConnection. That error chain can include full HTTP response bodies (e.g., initialize failed: status=..., body=...) and potentially large or sensitive data, so writing it verbatim to stderr/CI logs risks secret leakage and noisy output. Consider sanitizing/redacting and truncating the error string before printing (and keeping the console format consistent with other launcher stderr logs, e.g. using the [LAUNCHER] prefix).

Copilot uses AI. Check for mistakes.
logger.LogErrorWithServer(serverID, "backend", "Failed to create HTTP connection: %s, error=%v", serverID, err)
l.recordError(serverID, err.Error())
return nil, fmt.Errorf("failed to create HTTP connection: %w", err)
Expand Down