Conversation
…default Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/bd064680-5830-419d-b011-027a9ca720c8 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix documentation defaults for startupTimeout and toolTimeout
Fix incorrect default values in docs and example config for startup/tool timeouts and domain
Apr 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates user-facing documentation and the example TOML config to match the authoritative gateway defaults in internal/config/config_core.go (startup/tool timeouts) and to reflect that domain has no code-level default.
Changes:
- Correct
startupTimeoutdefault from60→30seconds in docs and example comments. - Correct
toolTimeoutdefault from120→60seconds in docs and example comments. - Update
domaindefault in docs fromlocalhost→(unset)to match code behavior.
Show a summary per file
| File | Description |
|---|---|
| docs/CONFIGURATION.md | Fixes the gateway config table defaults for domain, startupTimeout, and toolTimeout to match code. |
| config.example.toml | Fixes inline comment defaults for startup/tool timeouts while keeping non-default example values. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three documentation discrepancies between
config_core.goconstants and user-facing docs:startupTimeout/toolTimeoutdefaults were documented as 2× their actual values, anddomainwas documented as defaulting to"localhost"when it has no code-level default.Changes
docs/CONFIGURATION.md— Gateway config table:startupTimeout60→30,toolTimeout120→60,domaindefaultlocalhost→(unset)config.example.toml— Inline comments corrected:(default: 60)→(default: 30)and(default: 120)→(default: 60); explicit override values (60/120) intentionally kept as examples of non-default configurationAuthoritative source