Skip to content

fix(guard): use UTF-8 safe string truncation in output preview logging #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lietblue wants to merge 1 commit into from
Closed

fix(guard): use UTF-8 safe string truncation in output preview logging #3690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions guards/github-guard/rust-guard/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,11 +804,10 @@ pub extern "C" fn label_response(
};

// Log output preview for debugging
let output_preview = if output_json.len() > 500 {
&output_json[..500]
} else {
&output_json
};
// NOTICE: Use floor_char_boundary to avoid panicking on multi-byte
// UTF-8 characters (CJK, emoji, etc.) when byte 500 falls mid-char.
let preview_end = output_json.floor_char_boundary(500);
let output_preview = &output_json[..preview_end];
log_info(&format!(" path_output_preview={}", output_preview));

if output_json.len() as u32 > output_size {
Expand Down Expand Up @@ -935,11 +934,10 @@ pub extern "C" fn label_response(
};

// Log output preview for debugging
let output_preview = if output_json.len() > 500 {
&output_json[..500]
} else {
&output_json
};
// NOTICE: Use floor_char_boundary to avoid panicking on multi-byte
// UTF-8 characters (CJK, emoji, etc.) when byte 500 falls mid-char.
let preview_end = output_json.floor_char_boundary(500);
let output_preview = &output_json[..preview_end];
log_info(&format!(" output_preview={}", output_preview));

if output_json.len() as u32 > output_size {
Expand Down