Skip to content

fix: remove restrictive bash allowlist from go-logger workflow#3864

Merged
lpcox merged 1 commit intomainfrom
fix/go-logger-bash-allowlist
Apr 15, 2026
Merged

fix: remove restrictive bash allowlist from go-logger workflow#3864
lpcox merged 1 commit intomainfrom
fix/go-logger-bash-allowlist

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented Apr 15, 2026

Problem

The Go Logger Enhancement workflow failed (#3826) because the AWF sandbox blocked the agent's go build ./... command. The workflow had a restrictive bash allowlist that only permitted go build -o awmg, so the agent reported itself as incomplete, triggering failure handling.

Root cause

The go-logger.md workflow used an explicit bash command allowlist:

tools:
  bash:
    - "go build -o awmg"
    - "go test ./..."
    - ...

The Copilot agent tried go build ./... (a valid Go build command) which didn't match the allowlist exactly, so the AWF rejected it.

Fix

  1. Replace restrictive bash allowlist with bash: true — The AWF sandbox already provides security, so explicit command restrictions are unnecessary (per gh-aw best practices)
  2. Add go ecosystem identifier to network.allowed — Ensures Go module proxy access for builds
  3. Recompile lock file — Updated go-logger.lock.yml to reflect changes

Verification

  • gh aw compile go-logger succeeds
  • make agent-finished passes all checks

Closes #3826

The Go Logger Enhancement workflow (#3826) failed because the agent
tried to run 'go build ./...' but only 'go build -o awmg' was in the
bash allowlist. The AWF sandbox already provides security, so the
explicit command restrictions are unnecessary.

Changes:
- Remove restrictive bash command allowlist, use 'bash: true' instead
- Add 'go' ecosystem identifier to network.allowed for module downloads
- Recompile lock file

Closes #3826

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 15, 2026 14:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Go Logger Enhancement agentic workflow to avoid AWF sandbox rejections caused by an overly strict bash command allowlist, aligning the workflow with the typical “unrestricted bash within sandbox + network allowlisting” pattern used elsewhere in this repo.

Changes:

  • Expand network.allowed to include the go ecosystem so Go module/proxy access works during builds.
  • Replace the explicit bash command allowlist with bash: true to prevent valid Go build/test invocations from being blocked.
  • Recompile the workflow lock file to reflect the updated tool/network configuration.
Show a summary per file
File Description
.github/workflows/go-logger.md Enables go network access and removes the restrictive bash allowlist by switching to bash: true.
.github/workflows/go-logger.lock.yml Updates compiled lock output (allowed domains + Copilot CLI tool allowances) to match the workflow changes.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lpcox lpcox merged commit ab63553 into main Apr 15, 2026
13 checks passed
@lpcox lpcox deleted the fix/go-logger-bash-allowlist branch April 15, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aw] Go Logger Enhancement failed

2 participants