fix: remove restrictive bash allowlist from test-improver workflow#3887
Merged
fix: remove restrictive bash allowlist from test-improver workflow#3887
Conversation
The Test Improver workflow (#3838) failed because the agent tried to run 'make agent-finished' but the bash allowlist only permitted specific commands. The AWF sandbox already provides security. Changes: - Remove restrictive bash command allowlist, use 'bash: true' instead - Add 'go' ecosystem identifier to network.allowed for module downloads - Recompile lock file Closes #3838 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an overly restrictive bash command allowlist from the Test Improver agentic workflow so it can execute required make targets within the AWF sandbox, and updates networking rules to support Go module downloads.
Changes:
- Add
gotonetwork.allowedin the workflow frontmatter. - Replace the bash command allowlist with
bash: true. - Recompile the workflow lockfile to reflect the updated network/tool permissions.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-improver.md | Expands network allowlist for Go and enables unrestricted bash tool usage (per AWF sandbox model). |
| .github/workflows/test-improver.lock.yml | Regenerated compiled workflow to include the updated domain allowlist and tool permissions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Test Improver workflow failed (#3838) because the AWF sandbox blocked
make agent-finished— the workflow had a restrictive bash allowlist that only permitted specific commands likego test -v ./....Same root cause as #3826 (go-logger workflow).
Agent's report_incomplete reason:
Fix
bash: true(AWF sandbox provides security)goecosystem identifier tonetwork.allowedfor module downloadsCloses #3838