Skip to content

Harden CLI proxy GraphQL path handling with explicit /api/graphql regression coverage #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Apr 21, 2026
Merged

Harden CLI proxy GraphQL path handling with explicit /api/graphql regression coverage #4278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b03eb
Initial plan
Copilot Apr 21, 2026
fcfed11
test: add explicit /api/graphql proxy coverage in handler test
Copilot Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/proxy/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,10 @@ func TestServeHTTP_GraphQLPreservesQueryString(t *testing.T) {
wantPath string
}{
{name: "graphql path", path: "/graphql?foo=bar", wantPath: "/graphql?foo=bar"},
{name: "ghes api graphql path", path: "/api/graphql?foo=bar", wantPath: "/graphql?foo=bar"},
{name: "gh host prefixed graphql path", path: "/api/v3/graphql?foo=bar", wantPath: "/graphql?foo=bar"},
{name: "ghes api graphql path", path: "/api/graphql", wantPath: "/graphql"},
{name: "ghes api graphql path with query", path: "/api/graphql?foo=bar", wantPath: "/graphql?foo=bar"},
{name: "gh host prefixed graphql path", path: "/api/v3/graphql", wantPath: "/graphql"},
{name: "gh host prefixed graphql path with query", path: "/api/v3/graphql?foo=bar", wantPath: "/graphql?foo=bar"},
}

for _, tt := range tests {
Expand Down
Loading