Align CONTRIBUTING.md with actual make test-all rebuild behavior#4346
Merged
Align CONTRIBUTING.md with actual make test-all rebuild behavior#4346
CONTRIBUTING.md with actual make test-all rebuild behavior#4346Conversation
Agent-Logs-Url: https://github.com/github/gh-aw-mcpg/sessions/70f5ae37-d25c-4772-affd-ab3940db47a6 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix discrepancy in test-all command description
Align Apr 22, 2026
CONTRIBUTING.md with actual make test-all rebuild behavior
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor documentation so it accurately reflects the current Makefile behavior: make test-all always runs the build target first (because build is phony), while make test-integration only builds when the binary is missing.
Changes:
- Corrected the “Run All Tests” description in
CONTRIBUTING.mdto state thatmake test-allalways rebuilds first.
Show a summary per file
| File | Description |
|---|---|
CONTRIBUTING.md |
Aligns the “Run All Tests” documentation with Makefile behavior (test-all: build). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs reconciliation found a mismatch:
CONTRIBUTING.mddescribedmake test-allas conditionally building the binary, while the Makefile always rebuilds viatest-all: build(buildis phony). This PR updates the documentation text to match current behavior.Documentation correction
CONTRIBUTING.mdto state thatmake test-allalways rebuilds the binary first.Behavior now described accurately
make test-integrationremains conditionally built if binary is missing.make test-allremains unconditional rebuild, now reflected correctly in docs.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build2713270827/b509/launcher.test /tmp/go-build2713270827/b509/launcher.test -test.testlogfile=/tmp/go-build2713270827/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 metadata -o x_amd64/vet -W SVusT-1Bf 1546016/b287/ x_amd64/vet . --gdwarf2 --64 x_amd64/vet(dns block)/tmp/go-build3345081388/b513/launcher.test /tmp/go-build3345081388/b513/launcher.test -test.testlogfile=/tmp/go-build3345081388/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s 2646�� /tmp/go-build2352646787/b046/vet.cfg .cfg 64/pkg/tool/linux_amd64/vet go1.25.9 -c=4 -nolocalimports U-uEwzGxi3-_ -uns�� /tmp/go-build2352646787/b135/vet.cfg /opt/hostedtoolcache/go/1.25.9/x64/src/encoding/-ifaceassert 878737dd1094c2f3-d 64/src/runtime/c/tmp/go-build3345081388/b501/difc.test --local ache/go/1.25.9/x-test.paniconexit0 64/pkg/tool/linu-test.timeout=10m0s(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build2713270827/b491/config.test /tmp/go-build2713270827/b491/config.test -test.testlogfile=/tmp/go-build2713270827/b491/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true /sig.s elemetry.io/otel-ifaceassert x_amd64/vet --gdwarf-5 credentials lcache/go/1.25.9-bool x_amd64/vet -p g_.a -trimpath x_amd64/vet -I telabs/wazero/in-atomic -I x_amd64/vet(dns block)/tmp/go-build3345081388/b495/config.test /tmp/go-build3345081388/b495/config.test -test.testlogfile=/tmp/go-build3345081388/b495/testlog.txt -test.paniconexit0 -test.timeout=10m0s estl�� 2646787/b295/vet-errorsas -trimpath 64/pkg/tool/linu-nilfunc -p encoding/gob -lang=go1.25 64/pkg/tool/linu-tests 2646�� /tmp/go-build2352646787/b046/vet.cfg .cfg 64/pkg/tool/linux_amd64/vet go1.25.9 -c=4 -nolocalimports 64/pkg/tool/linuorigin(dns block)nonexistent.local/tmp/go-build2713270827/b509/launcher.test /tmp/go-build2713270827/b509/launcher.test -test.testlogfile=/tmp/go-build2713270827/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 metadata -o x_amd64/vet -W SVusT-1Bf 1546016/b287/ x_amd64/vet . --gdwarf2 --64 x_amd64/vet(dns block)/tmp/go-build3345081388/b513/launcher.test /tmp/go-build3345081388/b513/launcher.test -test.testlogfile=/tmp/go-build3345081388/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s 2646�� /tmp/go-build2352646787/b046/vet.cfg .cfg 64/pkg/tool/linux_amd64/vet go1.25.9 -c=4 -nolocalimports U-uEwzGxi3-_ -uns�� /tmp/go-build2352646787/b135/vet.cfg /opt/hostedtoolcache/go/1.25.9/x64/src/encoding/-ifaceassert 878737dd1094c2f3-d 64/src/runtime/c/tmp/go-build3345081388/b501/difc.test --local ache/go/1.25.9/x-test.paniconexit0 64/pkg/tool/linu-test.timeout=10m0s(dns block)slow.example.com/tmp/go-build2713270827/b509/launcher.test /tmp/go-build2713270827/b509/launcher.test -test.testlogfile=/tmp/go-build2713270827/b509/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true g_.a -I x_amd64/vet --gdwarf-5 metadata -o x_amd64/vet -W SVusT-1Bf 1546016/b287/ x_amd64/vet . --gdwarf2 --64 x_amd64/vet(dns block)/tmp/go-build3345081388/b513/launcher.test /tmp/go-build3345081388/b513/launcher.test -test.testlogfile=/tmp/go-build3345081388/b513/testlog.txt -test.paniconexit0 -test.timeout=10m0s 2646�� /tmp/go-build2352646787/b046/vet.cfg .cfg 64/pkg/tool/linux_amd64/vet go1.25.9 -c=4 -nolocalimports U-uEwzGxi3-_ -uns�� /tmp/go-build2352646787/b135/vet.cfg /opt/hostedtoolcache/go/1.25.9/x64/src/encoding/-ifaceassert 878737dd1094c2f3-d 64/src/runtime/c/tmp/go-build3345081388/b501/difc.test --local ache/go/1.25.9/x-test.paniconexit0 64/pkg/tool/linu-test.timeout=10m0s(dns block)this-host-does-not-exist-12345.com/tmp/go-build2713270827/b518/mcp.test /tmp/go-build2713270827/b518/mcp.test -test.testlogfile=/tmp/go-build2713270827/b518/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true .cfg olang.org/grpc@v-ifaceassert x_amd64/vet . 1546016/b245/ --64 x_amd64/vet 1546�� .cfg olang.org/grpc@v1.80.0/health/gr-ifaceassert x_amd64/vet -pthread g/grpc/metadata -fmessage-length--version x_amd64/vet(dns block)/tmp/go-build3345081388/b522/mcp.test /tmp/go-build3345081388/b522/mcp.test -test.testlogfile=/tmp/go-build3345081388/b522/testlog.txt -test.paniconexit0 -test.timeout=10m0s(dns block)If you need me to access, download, or install something from one of these locations, you can either: