Skip to content

fix: register flag completion functions for config, log-dir, payload-dir, env #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Apr 23, 2026
+13 −5
Merged

fix: register flag completion functions for config, log-dir, payload-dir, env #4413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions internal/cmd/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,19 @@ func registerAllFlags(cmd *cobra.Command) {

// registerFlagCompletions registers custom completion functions for flags
func registerFlagCompletions(cmd *cobra.Command) {
// File and directory completions using idiomatic cobra helpers
cmd.MarkFlagFilename("config", "toml")
cmd.MarkFlagDirname("log-dir")
cmd.MarkFlagDirname("payload-dir")
cmd.MarkFlagFilename("env", "env")
// File and directory completions
cmd.RegisterFlagCompletionFunc("config", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return []string{"toml"}, cobra.ShellCompDirectiveFilterFileExt
})
cmd.RegisterFlagCompletionFunc("log-dir", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return nil, cobra.ShellCompDirectiveFilterDirs
})
cmd.RegisterFlagCompletionFunc("payload-dir", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return nil, cobra.ShellCompDirectiveFilterDirs
})
cmd.RegisterFlagCompletionFunc("env", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return []string{"env"}, cobra.ShellCompDirectiveFilterFileExt
})

// Enum completions for DIFC flags
cmd.RegisterFlagCompletionFunc("guards-mode", cobra.FixedCompletions(
Expand Down
Loading