Skip to content

Refactor DIFC label constructors to eliminate duplication #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Feb 5, 2026
Merged

Refactor DIFC label constructors to eliminate duplication #696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b5703b
Initial plan
Copilot Feb 5, 2026
b7e7608
Refactor DIFC label constructors to reduce duplication
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions internal/difc/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ func NewLabel() *Label {
return &Label{tags: make(map[Tag]struct{})}
}

// newLabelWithTags is a helper function that creates a label with the given tags.
// This helper reduces duplication in NewSecrecyLabelWithTags and NewIntegrityLabelWithTags.
func newLabelWithTags(tags []Tag) *Label {
label := NewLabel()
label.AddAll(tags)
return label
}

// Add adds a tag to this label
func (l *Label) Add(tag Tag) {
l.mu.Lock()
Expand Down Expand Up @@ -100,9 +108,7 @@ func NewSecrecyLabel() *SecrecyLabel {

// NewSecrecyLabelWithTags creates a secrecy label with the given tags
func NewSecrecyLabelWithTags(tags []Tag) *SecrecyLabel {
label := NewSecrecyLabel()
label.Label.AddAll(tags)
return label
return &SecrecyLabel{Label: newLabelWithTags(tags)}
}

// CanFlowTo checks if this secrecy label can flow to target
Expand Down Expand Up @@ -180,9 +186,7 @@ func NewIntegrityLabel() *IntegrityLabel {

// NewIntegrityLabelWithTags creates an integrity label with the given tags
func NewIntegrityLabelWithTags(tags []Tag) *IntegrityLabel {
label := NewIntegrityLabel()
label.Label.AddAll(tags)
return label
return &IntegrityLabel{Label: newLabelWithTags(tags)}
}

// CanFlowTo checks if this integrity label can flow to target
Expand Down
Loading