Fix large payload tester mount isolation - remove test data from gateway#733
Merged
Fix large payload tester mount isolation - remove test data from gateway#733
Conversation
…e it on-demand Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
… accessible to filesystem MCP server Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
… structure Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix large payload structure in shared directory usage
Fix large payload tester mount isolation - remove test data from gateway
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a mount isolation issue in the large-payload-tester workflow where test data was incorrectly mounted to the gateway container. The gateway uses Docker-in-Docker: when it launches backend MCP servers with volume mounts, the paths are relative to the host filesystem, not the gateway container's filesystem. Therefore, the gateway doesn't need test data mounted to pass it to child containers.
Changes:
- Removed
/tmp/mcp-test-fsmount from gateway container'ssandbox.mcp.mountsconfiguration - Removed
mkdir -p /tmp/jq-payloadsfrom setup step (gateway creates this on-demand viaMkdirAll) - Updated documentation to explain the isolation architecture and Docker-in-Docker behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/large-payload-tester.md | Removed test data mount from gateway, removed payload dir pre-creation, updated comment |
| .github/workflows/large-payload-tester.lock.yml | Compiled lock file with updated gateway Docker command and setup step |
| .github/workflows/large-payload-tester-README.md | Enhanced documentation with architecture diagram, flow description, and isolation principles |
| .github/agentics/large-payload-tester.md | Updated test protocol description to emphasize isolation and architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The large-payload-tester workflow had
/tmp/mcp-test-fs(test data) mounted to the gateway container, breaking test isolation. The gateway should only access test files through the filesystem MCP server via protocol, not direct filesystem access.Changes
/tmp/jq-payloads(payload dir) mounted, not/tmp/mcp-test-fs(test data)/tmp/jq-payloadson-demand viaMkdirAllwhen storing first payloadTechnical Detail
Gateway uses Docker-in-Docker (socket mounted). When launching backend MCP servers:
# Gateway executes this command (runs on host Docker daemon) docker run -v /tmp/mcp-test-fs:/workspace/test-data filesystem-mcp-serverThe path
/tmp/mcp-test-fsis relative to the host filesystem, not the gateway container's filesystem. Gateway container doesn't need this directory mounted to pass it to child containers.Result
Test data isolation ensures the gateway must retrieve files via MCP protocol, properly testing payload interception and storage.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.