Merged
Conversation
Update README.md to correctly indicate that HTTP transport is fully supported, not "not yet implemented". HTTP transport has been fully functional with complete implementation in internal/launcher/launcher.go, mcp.NewHTTPConnection(), and comprehensive test coverage in test/integration/http_backend_test.go and http_error_test.go. Fixes documentation discrepancy reported in issue. Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix HTTP transport documentation discrepancy
Fix HTTP transport documentation status
Feb 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the README to accurately reflect that the "http" transport type is implemented and supported, aligning documentation with the existing HTTP backend and tests.
Changes:
- Change README transport description for
"http"from “not yet implemented” to “fully supported”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md incorrectly states HTTP transport is "not yet implemented". The implementation exists in
internal/launcher/launcher.go,internal/mcp/connection.go, with integration test coverage intest/integration/http_backend_test.go.Changes
"http" - HTTP transport (not yet implemented)→"http" - HTTP transport (fully supported)Context
HTTP transport has been production-ready since implementation:
serverCfg.Type == "http"handling withmcp.NewHTTPConnection()http_backend_test.go,http_error_test.go, plus 40+ unit teststype: "http"withurlandheadersfieldsThis was the only incorrect "not yet implemented" reference in the codebase.
Original prompt
This section details on the original issue you should resolve
<issue_title>📚 Documentation Reconciliation Report - February 2026</issue_title>
<issue_description>## Summary
Found 1 critical discrepancy between documentation and implementation during nightly reconciliation check.
Critical Issues 🔴
Issues that would cause user confusion or broken workflows if followed:
1. HTTP Transport Incorrectly Documented as "Not Yet Implemented"
Location: README.md, line 140
Problem: Documentation states
"http"transport type is "not yet implemented":Actual Behavior: HTTP transport IS fully implemented and functional:
internal/launcher/launcher.gocontains complete HTTP backend support (lines checkingserverCfg.Type == "http")mcp.NewHTTPConnection()test/integration/http_backend_test.go,test/integration/http_error_test.goImpact: Users may avoid using HTTP transport thinking it's not available, when it's actually production-ready.
Suggested Fix: Change documentation to:
Code References:
internal/launcher/launcher.go- HTTP backend implementationinternal/mcp/connection.go- NewHTTPConnection functiontest/integration/http_backend_test.go- HTTP integration testsDocumentation Completeness
Accurate Sections ✅
Verified the following sections are correct and match implementation:
Environment Variables - All documented variables match code:
MCP_GATEWAY_PORT- Found ininternal/cmd/flags_core.goMCP_GATEWAY_DOMAIN- Found ininternal/cmd/flags_core.goMCP_GATEWAY_API_KEY- Found ininternal/cmd/flags_core.goMCP_GATEWAY_LOG_DIR- Found ininternal/cmd/flags_logging.goMCP_GATEWAY_PAYLOAD_DIR- Found ininternal/cmd/flags_logging.goMCP_GATEWAY_PAYLOAD_SIZE_THRESHOLD- Found ininternal/cmd/flags_logging.goMCP_GATEWAY_ENABLE_DIFC- Found ininternal/cmd/flags_difc.goConfiguration Structs - Verified against code:
StdinServerConfigfields match README documentationServerConfig(TOML) fields match README documentationGatewayConfigfields match README documentationMake Targets - All documented targets exist and work:
make build- Buildsawmgbinarymake test/make test-unit- Run unit tests in./internal/...make test-integration- Run binary integration tests intest/integration/make test-all- Run both unit and integration testsmake lint- Runs go vet, gofmt, and golangci-lintmake coverage- Unit tests with coverage reportmake format- Auto-formats with gofmtmake clean- Removes build artifactsmake install- Installs toolchains and dependenciesmake agent-finished- Complete verification pipelinemake release- Creates versioned release tagsProject Structure - CONTRIBUTING.md accurately lists:
internal/cmd/- CLI implementation (Cobra)internal/config/- Configuration parsing (TOML/JSON) with validationinternal/server/- HTTP server (routed/unified modes)internal/mcp/- MCP protocol types and JSON-RPC handlinginternal/launcher/- Backend process managementinternal/guard/- Security guards (NoopGuard active)internal/logger/- Debug logging frameworkinternal/auth/- Authentication logicinternal/timeutil/- Time formatting utilitiesinternal/tty/- Terminal detection utilitiesCLI Flags - README.md Usage section accurately documents all flags:
-c, --config- Path to config file--config-stdin- Read JSON configuration from stdin--enable-difc- Enable DIFC enforcement--env- Path to .env file-l, --listen- HTTP server listen address (default: "127.0.0.1:3000")--log-dir- Directory for log files (default: "/tmp/gh-aw/mcp-logs")--payload-dir- Directory for large payloads (default: "/tmp/jq-payloads")--payload-size-threshold- Size threshold for disk storage (default: 1024)--routed- Run in routed mode--sequential-launch- Launch servers sequentiall...✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.