-
Notifications
You must be signed in to change notification settings - Fork 47
Description
Objective
Run the zizmor security scanner to verify that the obfuscation issue count has been reduced from 126 to 0 (or near-zero) after recompiling workflows.
Context
From discussion #12933: After fixing the compiler and recompiling workflows, we should verify the fix by running the same static analysis tool that detected the issue.
Current State: 126 obfuscation warnings across 63 workflows
Expected State: 0-10 warnings (some may remain if legitimate)
Prerequisites
This task depends on:
- ✅ Compiler updated (Issue rejig docs #1)
- ✅ Tests pass (Issue Add workflow: githubnext/agentics/weekly-research #2)
- ✅ Workflows recompiled (Issue Add workflow: githubnext/agentics/weekly-research #3)
Approach
-
Install zizmor (if not already available):
cargo install zizmor # or appropriate installation method -
Run scan on recompiled workflows:
zizmor .github/workflows/*.lock.yml --format json > zizmor-results.json
-
Count obfuscation issues:
jq '[.results[].violations[] | select(.slug == "obfuscation")] | length' zizmor-results.json -
Review any remaining obfuscation warnings to determine if legitimate
Expected Results
Before Fix: 126 obfuscation warnings
After Fix: 0-10 warnings (ideally 0)
If any warnings remain, document:
- Which workflows still have the issue
- Why the compiler didn't fix them (dynamic values?)
- Whether they're legitimate use cases
Validation Checklist
- Zizmor installed and runs successfully
- Scan completes on all workflow files
- Obfuscation count significantly reduced (>90%)
- Remaining warnings (if any) are documented
- Results saved for comparison in future scans
Documentation
Create a summary comment in discussion #12933:
- Before: 126 obfuscation warnings
- After: X warnings
- Reduction: Y% improvement
- Remaining issues: [list if any]
Acceptance Criteria
- Zizmor scan runs successfully
- Obfuscation count reduced to <10
- Results documented in discussion comment
- Any remaining warnings explained
Related
Discussion #12933 - Static Analysis Report (Item 2: Obfuscation)
AI generated by Plan Command for discussion #12933