-
Notifications
You must be signed in to change notification settings - Fork 301
Description
🏥 CI Failure Investigation - Run #34277
Summary
CI run 34277 triggered by the "Use runtime-import macros for frontmatter imports" change now fails early: the lint-go job reports unformatted Go files, and Integration: Parser Location & Validation hits TestAgentImportWithToolsArray because the test still expects agent markdown in ImportsResult.MergedMarkdown even though runtime imports move the content into ImportPaths.
Failure Details
Root Cause Analysis
The lint-go job executes go fmt ./..., prints the message "❌ Code is not formatted. Run 'make fmt' to fix." and exits with status 1. The PR introduced Go files that have not been gofmt'd yet.
The integration test failure in pkg/parser/agent_import_integration_test.go:102 occurs because the updated runtime-import macro implementation treats imports without inputs as runtime imports and records them in ImportsResult.ImportPaths instead of inlining their markdown. The test still asserts that MergedMarkdown is non-empty, which no longer holds for imports without inputs.
Failed Jobs and Errors
lint-go:go fmt ./...stopped with exit code 1 after emitting the unformatted-files message.Integration: Parser Location & Validation:TestAgentImportWithToolsArrayfails withagent_import_integration_test.go:102: Expected MergedMarkdown to contain agent markdown content.
Investigation Findings
- Running
go fmt ./...(ormake fmt) on this branch should expose the specific files that need formatting; applying the formatter should resolve the lint failure. ProcessImportsFromFrontmatterWithManifestnow captures imports without inputs inImportPathsfor runtime-import macros, so custom agents imported without inputs no longer contribute toMergedMarkdown.
Recommended Actions
- Run
make fmt, commit the formatted Go files, and rerunlint-goso go fmt no longer reports unformatted files. - Update
TestAgentImportWithToolsArrayso it asserts that the agent import appears inImportsResult.ImportPaths(and thatMergedMarkdowncan stay empty when no inputs are provided) so the test covers the new runtime-import behavior.
Prevention Strategies
- Run
make fmtlocally before pushing Go changes solint-gonever sees unformatted files. - When a change introduces runtime-import macros, also update parser integration tests to match the new
ImportPaths/MergedMarkdowncontract.
AI Team Self-Improvement
- Reminder for future investigations: when runtime-import handling changes, double-check parser tests that inspect
MergedMarkdownand update them to look atImportPathsso they stay aligned with the new compile/runtime split.
Historical Context
- These failures appeared with the runtime-import macro change in this run; the same tests and lint step were green before the change, so the new behavior is triggering the regressions.
AI generated by CI Failure Doctor
To add this workflow in your repository, run
gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. See usage guide.
- expires on Feb 8, 2026, 5:06 PM UTC