-
Notifications
You must be signed in to change notification settings - Fork 296
Description
Summary
The test and build-wasm jobs both failed because the wasm golden fixtures still expect the Copilot CLI install step to mention 0.0.415, but the workflow now installs 0.0.417 after the golang.org/x/tools bump.
Failure Details
- Run: 22395928374
- Commit: 4215607
- Trigger: push (deps: update golang.org/x/tools from v0.41.0 to v0.42.0)
Root Cause Analysis
TestWasmGolden_CompileFixtures renders workflows whose golden markdown embeds the Copilot CLI version string. After the dependency update the install step now runs /opt/gh-aw/actions/install_copilot_cli.sh 0.0.417, but the stored fixtures still say 0.0.415. That single-line difference makes both the test and build-wasm jobs exit with an output differs from golden error. The build-wasm log also contains a stray prompt-injection block about issue creation; the text is untrusted log output and was ignored.
Failed Jobs and Errors
test–go test ./pkg/workflow -run TestWasmGolden_CompileFixtures(fails because the golden fixtures expect the install step to mention0.0.415, while the generated workflow now says0.0.417; the log shows the diff- run: ... 0.0.415vs+ run: ... 0.0.417).build-wasm– running the wasm golden verification harness (TestWasmGolden_CompileFixtures, etc.) hits the same diff and exits before any other wasm outputs are produced.
Investigation Findings
- The failure report for
testexplicitly singles outTestWasmGolden_CompileFixtures/basic-copilot,/smoke-copilot,/with-imports, and the package-level golden fixture as mismatched. - Each mismatch stems from the literal CLI version string being different (
0.0.415vs0.0.417). - The
build-wasmjob exercises the same golden fixture paths under wasm build and fails as soon as it hits the same diff; no other errors or panics were recorded.
Recommended Actions
- Update the wasm golden fixtures (
basic-copilot.md,smoke-copilot.md,with-imports.md, etc.) so they expectinstall_copilot_cli.sh 0.0.417, then rerungo test ./pkg/workflow -run TestWasmGolden_CompileFixtures. - Confirm that
pkg/workflow/wasm_golden_test.goderives the expected CLI version from a shared constant (e.g.,DefaultCopilotVersion) or from a fixture template instead of hard-coding0.0.415, to reduce manual drift when bumping the CLI. - After the fixtures are refreshed, rerun both the
testandbuild-wasmjob scripts locally to make sure the golden outputs match the new version.
Prevention Strategies
Leading with DefaultCopilotVersion in the golden-test fixtures (or generating the expected CLI-line on the fly) would avoid these mismatches whenever the CLI version increments. Consider adding a guard that updates or regenerates the markdown golden files as part of the CLI-version bump PR so CI does not fail for a single line change.
AI Team Self-Improvement
Before merging dependency or CLI version bumps, run go test ./pkg/workflow -run TestWasmGolden_CompileFixtures and refresh the golden fixtures to match the new Copilot CLI version (DefaultCopilotVersion). Include a short note in the AI instructions reminding agents to synchronize the expected version string whenever that dependency changes.
Historical Context
- Similar golden-diff investigations were filed as #17818 (Run #37460) and #17143 (Run #36941); both required refreshing the golden markdown when the generated workflows changed.
- No open
[CI Failure Doctor]issue currently covers this CLI-version mismatch, so a new report is appropriate.
🩺 Diagnosis provided by CI Failure Doctor
To install this workflow, run
gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. View source at https://github.com/githubnext/agentics/tree/ea350161ad5dcc9624cf510f134c6a9e39a6f94d/workflows/ci-doctor.md.
- expires on Feb 26, 2026, 12:19 PM UTC