Skip to content

[plan] Delete zombie test files from pkg/workflow/ (batch 2 of 2) #19240

@github-actions

Description

@github-actions

Objective

Delete the second batch of permanently-skipped "zombie" test files from pkg/workflow/. These files contain test functions that all unconditionally call t.Skip() with messages like "scripts now use require() pattern to load external files at runtime". They provide zero coverage and should be removed.

Context

Discussion #19223 identified 31 test files across the repo with 93 permanently-skipped functions (1,756 lines of non-functional test code) left behind after a JS architecture migration. This is the second half of the pkg/workflow/ cleanup (see also batch 1).

Files to Delete

Run git rm on these files:

git rm pkg/workflow/log_parser_new_format_test.go
git rm pkg/workflow/log_parser_snapshot_test.go
git rm pkg/workflow/log_parser_test.go
git rm pkg/workflow/main_export_validation_test.go
git rm pkg/workflow/noop_bundling_test.go
git rm pkg/workflow/patch_generation_test.go
git rm pkg/workflow/safe_inputs_http_integration_test.go
git rm pkg/workflow/safe_outputs_cjs_extension_test.go
git rm pkg/workflow/safe_outputs_github_token_test.go
git rm pkg/workflow/safe_outputs_mcp_bundler_integration_test.go
git rm pkg/workflow/safe_outputs_mcp_server_test.go
git rm pkg/workflow/staged_preview_bundling_test.go
git rm pkg/workflow/token_counting_test.go

Important: Before deleting each file, verify it only contains permanently-skipped test functions (all functions call t.Skip()). If a file has any non-skipped test functions, do NOT delete it — only remove the skipped functions.

Approach

  1. For each file, open it and confirm ALL test functions are skipped with the require() migration message
  2. Run git rm (file) for confirmed all-skip files
  3. Build and run tests to verify nothing breaks

Validation

go build ./...
go vet ./...
make fmt
make test-unit

Acceptance Criteria

  • All listed files verified as all-skip and deleted
  • make test-unit passes with no regressions
  • No non-skipped tests were accidentally removed

Generated by Plan Command for issue #discussion #19223

  • expires on Mar 4, 2026, 2:57 PM UTC

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions