-
Notifications
You must be signed in to change notification settings - Fork 296
Closed
Labels
Description
Objective
Remove permanently-skipped test functions from four pkg/cli/ test files. Unlike the pkg/workflow/ zombie files where entire files can be deleted, these files contain a mix of active and skipped functions — so only the skipped functions should be removed, not the entire files.
Context
Discussion #19223 identified 7 permanently-skipped test functions across 4 files in pkg/cli/. All skips use the require() migration message.
Files to Edit
| File | Skipped Functions to Remove |
|---|---|
pkg/cli/audit_test.go |
1 |
pkg/cli/logs_firewall_parse_test.go |
3 |
pkg/cli/logs_parse_test.go |
2 |
pkg/cli/mcp_inspect_safe_inputs_integration_test.go |
1 |
Approach
For each file:
- Open the file and identify all test functions that contain
t.Skip(...)with the message"scripts now use require() pattern"(or similar require() migration messages) - Remove those test functions entirely (including any helper functions that exist solely to support the skipped tests)
- Do NOT remove functions that are either:
- Not skipped
- Skipped for a different reason (e.g.,
// FIXMEskips)
Search pattern to find skipped functions:
grep -n "t.Skip" pkg/cli/audit_test.go pkg/cli/logs_firewall_parse_test.go pkg/cli/logs_parse_test.go pkg/cli/mcp_inspect_safe_inputs_integration_test.goValidation
go build ./...
go vet ./...
make fmt
make lint
make test-unitAcceptance Criteria
- All require()-migration-skipped test functions removed from the 4 files
- No non-skipped test functions accidentally removed
- Files still compile and pass
go vet -
make test-unitpasses with no regressions -
make lintpasses (no unused helper functions left behind)
Generated by Plan Command for issue #discussion #19223
- expires on Mar 4, 2026, 2:57 PM UTC
Reactions are currently unavailable