-
Notifications
You must be signed in to change notification settings - Fork 296
Closed
Labels
bugSomething isn't workingSomething isn't workingclienhancementNew feature or requestNew feature or requestworkflows
Description
Problem
gh aw add-wizard does not account for GHES repositories. Multiple steps fail:
- PR creation targets github.com instead of the GHES instance (filed as add-wizard and add --create-pull-request fail to create PR on GitHub Enterprise Server repositories #20875)
engine.api-targetis not auto-populated from the GHES API URL- Firewall allowed domains do not include the GHES hostname or
api.<ghes-host> GH_HOSTis not set in the generated workflow, soghCLI commands target github.com- Copilot licensing is not validated — the wizard completes successfully even if Copilot is not enabled on the GHES instance
Proposal
When gh aw add-wizard (or gh aw add) detects a GHES remote:
- Auto-set
GH_HOSTfor the PR creation step (fix for add-wizard and add --create-pull-request fail to create PR on GitHub Enterprise Server repositories #20875) - Auto-populate
engine.api-targetfrom the detectedGITHUB_API_URL - Auto-add the GHES hostname and
api.<ghes-host>to the firewall allowed domains in the generated lock file - Inject a "Configure gh for GHE" step that sets
GH_HOSTviaGITHUB_ENVearly in the workflow - Validate Copilot access by testing the token exchange endpoint, and warn if Copilot is not enabled
Workarounds we used
- Used
gh aw add(not wizard) + manualgh pr createfor PR creation - Manually added
GH_HOSTconfiguration step to the lock file - Manually added
contoso-aw.ghe.comandapi.contoso-aw.ghe.comto--allow-domainsin TWO places in the lock file (theawfcommand andGH_AW_ALLOWED_DOMAINSenv var)
Related
- add-wizard and add --create-pull-request fail to create PR on GitHub Enterprise Server repositories #20875 — Wizard PR creation fails on GHES
- API proxy routes Copilot model requests to GHES API instead of Copilot API on Enterprise Server gh-aw-firewall#1300 — API proxy routing on GHES
Reactions are currently unavailable
Metadata
Metadata
Labels
bugSomething isn't workingSomething isn't workingclienhancementNew feature or requestNew feature or requestworkflows