[Contribution Check Report] PR #21584 — refactor: extract pushSignedCommits to shared helper, add integration tests

[github-actions]

Contribution Check Report

Field	Value
PR	#21584
Author	Copilot (apps/copilot-swe-agent)
Verdict	🟢 Aligned
Quality	lgtm
On-topic	✅ yes
Follows process	✅ yes
Focused	✅ yes
New deps	✅ no
Has tests	✅ yes
Has description	✅ yes
Lines changed	740 (550 additions / 190 deletions)
Existing labels	(none)

---

Checklist Detail

1. On-topic — yes

The PR refactors pushSignedCommits out of create_pull_request.cjs and push_to_pull_request_branch.cjs into a standalone shared helper (push_signed_commits.cjs), and adds 8 comprehensive integration tests. This directly continues the work tracked in PR #21576 (signed-commit GraphQL replay) which implements the plan from issue #21572 — a core feature area of the project.

2. Follows process — yes

CONTRIBUTING.md mandates that PRs be created by the core team using Copilot or local agents. This PR is authored by the Copilot SWE agent (apps/copilot-swe-agent) and targets the dedicated agentic branch copilot/implement-feature-plan as a sub-PR of #21576. This is exactly the prescribed workflow.

3. Focused — yes

The PR does one thing: DRYs up the ~92-line inline pushSignedCommits function that was duplicated verbatim in two files, extracts it to a shared module, and provides dedicated integration test coverage. There are no unrelated changes.

4. New dependencies — no

No changes to package.json, go.mod, go.sum, or any other dependency manifest.

5. Has tests — yes

push_signed_commits.test.cjs is newly added with 433 lines covering 8 integration scenarios using a real bare git repo as a local remote with a mocked GraphQL layer (single commit, multiple commits, file deletions, empty commit, no new commits, GraphQL failure/fallback, multi-line commit body, subject-only message).

6. Has description — yes

The PR body provides a clear summary of the motivation (DRY up ~92-line duplicate), lists each changed file with its role, and includes a full scenario table for the new tests. Excellent quality description.

---

Comment Posted to PR

🟢 Looking good, @Copilot! This is a clean, focused refactor — pulling the ~92-line pushSignedCommits duplicate out into a proper shared module is exactly the right call, and the 8-scenario integration test suite for push_signed_commits.test.cjs is thorough. The PR description is clear and well-structured. Everything looks aligned with the project's contribution guidelines and the agentic workflow chain from issue #21572 → PR #21576 → this sub-PR. Ready for maintainer review. 🎉

Generated by Contribution Check · ◷

• expires on Mar 19, 2026, 1:34 PM UTC

[github-actions]

This issue is being closed as outdated. A newer issue has been created: #21621

View newer issue

---

This action was performed automatically by the Contribution Check workflow.