Skip to content

[performance] Regression in Validation: 10.9% slower #22137

@github-actions

Description

@github-actions

📊 Performance Regression Detected

Benchmark: BenchmarkValidation

Current Performance: 6.93ms (6,932,235 ns/op)
Historical Average: 6.25ms (6,253,557 ns/op)
Change: +10.9% slower
Detected On: 2026-03-21

📈 Detailed Performance Metrics

Performance Comparison

Metric Value
Current ns/op 6,932,235
Historical avg ns/op 6,253,557
Change +10.9% 🔴
Data Points Used 6
Memory (today) 2,589,056 B/op
Allocations (today) 29,375 allocs/op

Historical Data (last 7 days)

Date ns/op
2026-03-15 6,181,099
2026-03-16 6,147,981
2026-03-17 6,244,522
2026-03-18 6,204,119
2026-03-19 6,177,035
2026-03-20 6,566,583
2026-03-21 6,932,235 ⚠️

Observations

The validation phase has been creeping upward:

  • 2026-03-20 already showed a +5.3% increase (warning level)
  • 2026-03-21 crossed the 10% regression threshold
  • This suggests a gradual regression, not a sudden spike

💡 Recommended Actions

  1. Review recent changes to validation logic in pkg/workflow/ — particularly validators added or modified recently
  2. Run go test -bench=BenchmarkValidation -benchmem -cpuprofile=cpu.prof ./pkg/workflow/
  3. Use go tool pprof cpu.prof to identify which validation rules are most expensive
  4. Check if any new validators were added that run on every workflow field
  5. Note: The gradual increase over 2 days suggests accumulated validation work, not a single large change
📋 Additional Context
  • Run ID: §23381791533
  • Date: 2026-03-21
  • Workflow: Daily CLI Performance
  • Benchmark command: make bench-performance
  • Related: Validation phase also contributes to CompileSimpleWorkflow (+8.1% warning) and CompileComplexWorkflow (+40.4% regression)

References:

Generated by Daily CLI Performance Agent ·

  • expires on Mar 23, 2026, 2:40 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions