Skip to content

[Contribution Check Report] PR #22310 β€” docs(sandbox): remove Custom AWF/MCP Gateway Configuration sectionsΒ #22320

@github-actions

Description

@github-actions

Contribution Check Report

Field Result
PR #22310
Author Copilot (copilot-swe-agent)
Verdict 🟒 Aligned
Quality lgtm
On-topic βœ… yes
Follows process βœ… yes
Focused βœ… yes
New deps βœ… no
Has tests βœ… yes
Has description βœ… yes
Lines changed 634 (+408 / βˆ’226)
Existing labels (none)

Checklist Rationale

On-topic (yes): The PR removes internal-only fields (sandbox.agent.command/args/env, sandbox.mcp.container/version/entrypoint/args/entrypointArgs) from the public reference docs and enforces that boundary through a new strict-mode validation (validateStrictSandboxCustomization). This is squarely within the project's scope of building and governing GitHub Agentic Workflows.

Follows process (yes): The author is copilot-swe-agent β€” the Copilot coding agent explicitly identified in CONTRIBUTING.md as the core team's primary vehicle for creating and managing pull requests. The PR is assigned to pelikhan, a core team member. This is exactly the agentic development process the guidelines describe.

Focused (yes): Every file touched tells one coherent story β€” "make internal sandbox customisation fields truly internal":

  • docs/src/content/docs/reference/sandbox.md / frontmatter-full.md β€” remove the public documentation for those fields
  • pkg/parser/schemas/main_workflow_schema.json β€” add x-internal: true markers
  • scripts/generate-schema-docs.js β€” skip x-internal fields during doc generation
  • pkg/workflow/strict_mode_sandbox_validation.go + _test.go β€” enforce at compile time in strict mode
  • .github/workflows/*.lock.yml / *.md β€” automated hash updates triggered by the schema change (expected noise)

Has tests (yes): Three test files are added/modified β€” including a new strict_mode_sandbox_validation_test.go with 184 lines covering nil configs, allowed fields, and each forbidden field individually.

No new deps: go.mod / go.sum are untouched.


Suggested PR Comment

Hey @Copilot πŸ‘‹ β€” great work on locking down the internal sandbox configuration fields! The approach is clean: x-internal schema markers feed straight into both the doc generator and the strict-mode validator, so the enforcement is consistent end-to-end. The test coverage for validateStrictSandboxCustomization is thorough. This looks ready for maintainer review. πŸš€

Generated by Contribution Check Β· β—·

  • expires on Mar 23, 2026, 9:08 PM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions