-
Notifications
You must be signed in to change notification settings - Fork 312
Description
Contribution Check Report
| Field | Result |
|---|---|
| PR | #22310 |
| Author | Copilot (copilot-swe-agent) |
| Verdict | π’ Aligned |
| Quality | lgtm |
| On-topic | β yes |
| Follows process | β yes |
| Focused | β yes |
| New deps | β no |
| Has tests | β yes |
| Has description | β yes |
| Lines changed | 634 (+408 / β226) |
| Existing labels | (none) |
Checklist Rationale
On-topic (yes): The PR removes internal-only fields (sandbox.agent.command/args/env, sandbox.mcp.container/version/entrypoint/args/entrypointArgs) from the public reference docs and enforces that boundary through a new strict-mode validation (validateStrictSandboxCustomization). This is squarely within the project's scope of building and governing GitHub Agentic Workflows.
Follows process (yes): The author is copilot-swe-agent β the Copilot coding agent explicitly identified in CONTRIBUTING.md as the core team's primary vehicle for creating and managing pull requests. The PR is assigned to pelikhan, a core team member. This is exactly the agentic development process the guidelines describe.
Focused (yes): Every file touched tells one coherent story β "make internal sandbox customisation fields truly internal":
docs/src/content/docs/reference/sandbox.md/frontmatter-full.mdβ remove the public documentation for those fieldspkg/parser/schemas/main_workflow_schema.jsonβ addx-internal: truemarkersscripts/generate-schema-docs.jsβ skipx-internalfields during doc generationpkg/workflow/strict_mode_sandbox_validation.go+_test.goβ enforce at compile time in strict mode.github/workflows/*.lock.yml/*.mdβ automated hash updates triggered by the schema change (expected noise)
Has tests (yes): Three test files are added/modified β including a new strict_mode_sandbox_validation_test.go with 184 lines covering nil configs, allowed fields, and each forbidden field individually.
No new deps: go.mod / go.sum are untouched.
Suggested PR Comment
Hey
@Copilotπ β great work on locking down the internal sandbox configuration fields! The approach is clean:x-internalschema markers feed straight into both the doc generator and the strict-mode validator, so the enforcement is consistent end-to-end. The test coverage forvalidateStrictSandboxCustomizationis thorough. This looks ready for maintainer review. π
Generated by Contribution Check Β· β·
- expires on Mar 23, 2026, 9:08 PM UTC