Skip to content

[function-namer] Go function rename plan: codemod_plugins.go #25787

@github-actions

Description

@github-actions

Why This Matters

When AI coding agents search for functions to complete a task, they rely on function names to understand what code does. Clear, descriptive names increase the likelihood that an agent will find the right function instead of reimplementing existing logic.

Files Analyzed: pkg/cli/codemod_mcp_scripts.go, pkg/cli/codemod_network_firewall.go, pkg/cli/codemod_permissions_read.go, pkg/cli/codemod_permissions_write.go, pkg/cli/codemod_playwright_domains.go, pkg/cli/codemod_plugins.go
Analysis Date: 2026-04-11
Round-Robin Position: files 57–62 of 667 total
Function Budget: ~10 functions across 6 files

Rename Suggestions

pkg/cli/codemod_plugins.go

Current Name Suggested Name Reason
rewritePluginsBlock() rewritePluginsBlockToDependencies() Name omits the target format; an agent searching for "convert plugins block to dependencies" won't recognize this as the function doing that transformation
rewriteObjectFormatPlugins() rewriteObjectFormatPluginsToDependencies() Same issue — the output format (dependencies) is missing from the name, making the function's purpose ambiguous when browsing

All functions in codemod_plugins.go (for reference):

  • getPluginsToDependenciesCodemod() — ✅ Clear, no change needed
  • migratePluginsToDependencies() — ✅ Clear, no change needed
  • rewritePluginsBlock()⚠️ Rename suggested (see table above)
  • rewriteObjectFormatPlugins()⚠️ Rename suggested (see table above)

All other analyzed files — all functions already have clear, descriptive names:

  • getMCPScriptsModeCodemod() — ✅ Clear
  • getNetworkFirewallCodemod() — ✅ Clear
  • getExpandPermissionsShorthandCodemod() — ✅ Clear
  • getMigrateWritePermissionsToReadCodemod() — ✅ Clear
  • getPlaywrightDomainsToNetworkAllowedCodemod() — ✅ Clear
  • removeFieldFromPlaywright() — ✅ Clear (private helper, fieldName is a parameter)

🤖 Agentic Implementation Plan

Agentic Implementation Plan

This issue is designed to be assigned to a coding agent. The agent should implement all rename suggestions below in a single pull request.

Prerequisites

  • Read each rename suggestion and verify it is accurate by reviewing the function body
  • Check for any Go interface constraints that prevent renaming (e.g., must match interface method name)

Implementation Steps

1. Rename rewritePluginsBlockrewritePluginsBlockToDependencies in pkg/cli/codemod_plugins.go

// Old
func rewritePluginsBlock(block []string) ([]string, bool) {

// New
func rewritePluginsBlockToDependencies(block []string) ([]string, bool) {

2. Update all call sites for rewritePluginsBlock

grep -rn "rewritePluginsBlock" pkg/ --include="*.go"

Known caller: migratePluginsToDependencies in pkg/cli/codemod_plugins.go (line 81).

Also check test files:

grep -rn "rewritePluginsBlock" pkg/ --include="*_test.go"

3. Rename rewriteObjectFormatPluginsrewriteObjectFormatPluginsToDependencies in pkg/cli/codemod_plugins.go

// Old
func rewriteObjectFormatPlugins(block []string, indent string) ([]string, bool) {

// New
func rewriteObjectFormatPluginsToDependencies(block []string, indent string) ([]string, bool) {

4. Update all call sites for rewriteObjectFormatPlugins

grep -rn "rewriteObjectFormatPlugins" pkg/ --include="*.go"

Known caller: rewritePluginsBlock in pkg/cli/codemod_plugins.go (line 121).

Also check test files:

grep -rn "rewriteObjectFormatPlugins" pkg/ --include="*_test.go"

5. Verify compilation after renames

make build

6. Run tests after all renames are complete

make test-unit
make lint
```

### Commit Convention

Each rename should be a focused commit:

```
refactor: rename rewritePluginsBlock to rewritePluginsBlockToDependencies for clarity
refactor: rename rewriteObjectFormatPlugins to rewriteObjectFormatPluginsToDependencies for clarity

Validation Checklist

  • All renames implemented
  • All call sites updated (Go files and test files)
  • make build passes with no errors
  • make test-unit passes
  • make lint passes
  • PR description explains the agent-discoverability rationale

Notes for the Agent

  • This is a pure rename refactor — behavior must not change, only names
  • Both functions are unexported and only called within pkg/cli/codemod_plugins.go — changes are localized
  • Follow existing naming conventions documented in AGENTS.md

Generated by the Daily Go Function Namer workflow
Run: §24281111564

Generated by Daily Go Function Namer · ● 134.9K ·

  • expires on Apr 18, 2026, 11:08 AM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions