Skip to content

[ci-coach] ci: remove disabled job and standardize artifact retention #131 #26044

@github-actions

Description

@github-actions

CI Optimization Proposal

Summary

Two targeted cleanup improvements identified from analysis of 100 recent CI runs and the full workflow configuration (3137 lines):

  • Test coverage is excellent: 5479/5479 tests are covered by the CI matrix — no gaps
  • All fuzz tests passing: No crashes found in any of the 4 fuzz matrix groups
  • Parallelism is already well-optimized: integration tests run in parallel with unit tests

Optimizations

1. Remove permanently disabled logs-token-check job

Type: Dead code removal
Impact: ~100 lines removed, cleaner CI configuration
Risk: None

The logs-token-check job has if: false — it never runs under any condition. Removing it eliminates confusion about why a "token check" job exists but never executes, and reduces the workflow file by ~100 lines.

2. Reduce audit artifact retention from 30 to 14 days

Type: Artifact management
Impact: Standardized retention policy, minor artifact storage savings
Risk: None

All other artifact uploads in the workflow use 14-day retention. The dependency-audit artifact was the only outlier at 30 days. Audit data doesn't need to be kept longer than other test results for debugging recent changes.

Expected Impact

  • Lines reduced: ~102 (from 3137 → 3036)
  • Storage savings: Minor (14 fewer days of audit artifact storage per run)
  • Risk Level: None

Validation Results

✅ YAML syntax validated (python3 -c "import yaml; yaml.safe_load(...)")
✅ Changes are YAML-only — no Go code affected

No Further Optimizations Warranted

The CI is already well-structured:

  • All 5,479 tests are executed (canary analysis confirms 100% coverage)
  • Integration tests run in parallel with unit tests (no unnecessary blocking)
  • Job matrix is well-balanced across 23 groups
  • Fuzz tests run main-only with no failures or crashes found

Proposed by CI Coach workflow run #131


Warning

Protected Files — Push Permission Denied

This was originally intended as a pull request, but the patch modifies protected files. A human must create the pull request manually.

Protected files

The push was rejected because GitHub Actions does not have workflows permission to push these changes, and is never allowed to make such changes, or other authorization being used does not have this permission.

Create the pull request manually
# Download the patch from the workflow run
gh run download 24346577689 -n agent -D /tmp/agent-24346577689

# Create a new branch
git checkout -b ci-coach/remove-disabled-job-reduce-retention-665bc4bbbc5ef66d main

# Apply the patch (--3way handles cross-repo patches)
git am --3way /tmp/agent-24346577689/aw-ci-coach-remove-disabled-job-reduce-retention.patch

# Push the branch and create the pull request
git push origin ci-coach/remove-disabled-job-reduce-retention-665bc4bbbc5ef66d
gh pr create --title '[ci-coach] ci: remove disabled job and standardize artifact retention #131' --base main --head ci-coach/remove-disabled-job-reduce-retention-665bc4bbbc5ef66d --repo github/gh-aw

Generated by CI Optimization Coach · ● 3.6M ·

  • expires on Apr 15, 2026, 1:57 PM UTC

Metadata

Metadata

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions